* [Qemu-devel] [PATCH] hw/acpi: ACPI_PCI should depends on both ACPI and PCI
@ 2019-05-17 0:51 Wei Yang
2019-05-17 1:44 ` Richard Henderson
2019-05-17 11:11 ` Igor Mammedov
0 siblings, 2 replies; 6+ messages in thread
From: Wei Yang @ 2019-05-17 0:51 UTC (permalink / raw)
To: qemu-devel; +Cc: imammedo, Wei Yang, mst
Pointed out by Philippe Mathieu-Daudé <philmd@redhat.com>.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
hw/acpi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/acpi/Kconfig b/hw/acpi/Kconfig
index 7265843cc3..7c59cf900b 100644
--- a/hw/acpi/Kconfig
+++ b/hw/acpi/Kconfig
@@ -25,7 +25,7 @@ config ACPI_NVDIMM
config ACPI_PCI
bool
- depends on ACPI
+ depends on ACPI && PCI
config ACPI_VMGENID
bool
--
2.19.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] hw/acpi: ACPI_PCI should depends on both ACPI and PCI
2019-05-17 0:51 [Qemu-devel] [PATCH] hw/acpi: ACPI_PCI should depends on both ACPI and PCI Wei Yang
@ 2019-05-17 1:44 ` Richard Henderson
2019-05-17 11:11 ` Igor Mammedov
1 sibling, 0 replies; 6+ messages in thread
From: Richard Henderson @ 2019-05-17 1:44 UTC (permalink / raw)
To: Wei Yang, qemu-devel; +Cc: imammedo, mst
On 5/16/19 5:51 PM, Wei Yang wrote:
> Pointed out by Philippe Mathieu-Daudé <philmd@redhat.com>.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> ---
> hw/acpi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/acpi: ACPI_PCI should depends on both ACPI and PCI
2019-05-17 0:51 [Qemu-devel] [PATCH] hw/acpi: ACPI_PCI should depends on both ACPI and PCI Wei Yang
2019-05-17 1:44 ` Richard Henderson
@ 2019-05-17 11:11 ` Igor Mammedov
2019-05-17 12:59 ` Wei Yang
1 sibling, 1 reply; 6+ messages in thread
From: Igor Mammedov @ 2019-05-17 11:11 UTC (permalink / raw)
To: Wei Yang; +Cc: qemu-devel, mst
On Fri, 17 May 2019 08:51:14 +0800
Wei Yang <richardw.yang@linux.intel.com> wrote:
> Pointed out by Philippe Mathieu-Daudé <philmd@redhat.com>.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> ---
> hw/acpi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/acpi/Kconfig b/hw/acpi/Kconfig
> index 7265843cc3..7c59cf900b 100644
> --- a/hw/acpi/Kconfig
> +++ b/hw/acpi/Kconfig
> @@ -25,7 +25,7 @@ config ACPI_NVDIMM
>
> config ACPI_PCI
> bool
> - depends on ACPI
> + depends on ACPI && PCI
>
> config ACPI_VMGENID
> bool
are you sure you didn't miss anything?
On Fri, 17 May 2019 10:37:42 +0200
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
[...]
>
> config ARM_VIRT
> ...
> select ACPI_PCI
>
> config ACPI_PCI
> bool
> depends on ACPI && PCI
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/acpi: ACPI_PCI should depends on both ACPI and PCI
2019-05-17 11:11 ` Igor Mammedov
@ 2019-05-17 12:59 ` Wei Yang
2019-05-17 14:29 ` Igor Mammedov
0 siblings, 1 reply; 6+ messages in thread
From: Wei Yang @ 2019-05-17 12:59 UTC (permalink / raw)
To: Igor Mammedov; +Cc: mst, Wei Yang, qemu-devel
On Fri, May 17, 2019 at 01:11:16PM +0200, Igor Mammedov wrote:
>On Fri, 17 May 2019 08:51:14 +0800
>Wei Yang <richardw.yang@linux.intel.com> wrote:
>
>> Pointed out by Philippe Mathieu-Daud?? <philmd@redhat.com>.
>>
>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>> ---
>> hw/acpi/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/acpi/Kconfig b/hw/acpi/Kconfig
>> index 7265843cc3..7c59cf900b 100644
>> --- a/hw/acpi/Kconfig
>> +++ b/hw/acpi/Kconfig
>> @@ -25,7 +25,7 @@ config ACPI_NVDIMM
>>
>> config ACPI_PCI
>> bool
>> - depends on ACPI
>> + depends on ACPI && PCI
>>
>> config ACPI_VMGENID
>> bool
>
>are you sure you didn't miss anything?
>
This patch is based on the comment in
http://qemu.11.n7.nabble.com/PATCH-v4-0-6-Extract-build-mcfg-tt650106.html#a655913
My understanding is not correct?
>On Fri, 17 May 2019 10:37:42 +0200
>Philippe Mathieu-Daud?? <philmd@redhat.com> wrote:
>
>[...]
>>
>> config ARM_VIRT
>> ...
>> select ACPI_PCI
>>
>> config ACPI_PCI
>> bool
>> depends on ACPI && PCI
>>
>
>
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/acpi: ACPI_PCI should depends on both ACPI and PCI
2019-05-17 12:59 ` Wei Yang
@ 2019-05-17 14:29 ` Igor Mammedov
2019-05-20 0:35 ` Wei Yang
0 siblings, 1 reply; 6+ messages in thread
From: Igor Mammedov @ 2019-05-17 14:29 UTC (permalink / raw)
To: Wei Yang; +Cc: mst, Wei Yang, qemu-devel
On Fri, 17 May 2019 12:59:57 +0000
Wei Yang <richard.weiyang@gmail.com> wrote:
> On Fri, May 17, 2019 at 01:11:16PM +0200, Igor Mammedov wrote:
> >On Fri, 17 May 2019 08:51:14 +0800
> >Wei Yang <richardw.yang@linux.intel.com> wrote:
> >
> >> Pointed out by Philippe Mathieu-Daud?? <philmd@redhat.com>.
> >>
> >> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> >> ---
> >> hw/acpi/Kconfig | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/hw/acpi/Kconfig b/hw/acpi/Kconfig
> >> index 7265843cc3..7c59cf900b 100644
> >> --- a/hw/acpi/Kconfig
> >> +++ b/hw/acpi/Kconfig
> >> @@ -25,7 +25,7 @@ config ACPI_NVDIMM
> >>
> >> config ACPI_PCI
> >> bool
> >> - depends on ACPI
> >> + depends on ACPI && PCI
> >>
> >> config ACPI_VMGENID
> >> bool
> >
> >are you sure you didn't miss anything?
> >
>
> This patch is based on the comment in
> http://qemu.11.n7.nabble.com/PATCH-v4-0-6-Extract-build-mcfg-tt650106.html#a655913
>
> My understanding is not correct?
That wasn't the end of discussion, it continued on until Philippe suggested
the below changes
>
> >On Fri, 17 May 2019 10:37:42 +0200
> >Philippe Mathieu-Daud?? <philmd@redhat.com> wrote:
> >
> >[...]
> >>
> >> config ARM_VIRT
> >> ...
> >> select ACPI_PCI
> >>
> >> config ACPI_PCI
> >> bool
> >> depends on ACPI && PCI
> >>
> >
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/acpi: ACPI_PCI should depends on both ACPI and PCI
2019-05-17 14:29 ` Igor Mammedov
@ 2019-05-20 0:35 ` Wei Yang
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yang @ 2019-05-20 0:35 UTC (permalink / raw)
To: Igor Mammedov; +Cc: qemu-devel, mst, Wei Yang, Wei Yang
On Fri, May 17, 2019 at 04:29:03PM +0200, Igor Mammedov wrote:
>On Fri, 17 May 2019 12:59:57 +0000
>Wei Yang <richard.weiyang@gmail.com> wrote:
>
>> On Fri, May 17, 2019 at 01:11:16PM +0200, Igor Mammedov wrote:
>> >On Fri, 17 May 2019 08:51:14 +0800
>> >Wei Yang <richardw.yang@linux.intel.com> wrote:
>> >
>> >> Pointed out by Philippe Mathieu-Daud?? <philmd@redhat.com>.
>> >>
>> >> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>> >> ---
>> >> hw/acpi/Kconfig | 2 +-
>> >> 1 file changed, 1 insertion(+), 1 deletion(-)
>> >>
>> >> diff --git a/hw/acpi/Kconfig b/hw/acpi/Kconfig
>> >> index 7265843cc3..7c59cf900b 100644
>> >> --- a/hw/acpi/Kconfig
>> >> +++ b/hw/acpi/Kconfig
>> >> @@ -25,7 +25,7 @@ config ACPI_NVDIMM
>> >>
>> >> config ACPI_PCI
>> >> bool
>> >> - depends on ACPI
>> >> + depends on ACPI && PCI
>> >>
>> >> config ACPI_VMGENID
>> >> bool
>> >
>> >are you sure you didn't miss anything?
>> >
>>
>> This patch is based on the comment in
>> http://qemu.11.n7.nabble.com/PATCH-v4-0-6-Extract-build-mcfg-tt650106.html#a655913
>>
>> My understanding is not correct?
>
>That wasn't the end of discussion, it continued on until Philippe suggested
>the below changes
>
Yep, just see the latest reply.
>>
>> >On Fri, 17 May 2019 10:37:42 +0200
>> >Philippe Mathieu-Daud?? <philmd@redhat.com> wrote:
>> >
>> >[...]
>> >>
>> >> config ARM_VIRT
>> >> ...
>> >> select ACPI_PCI
>> >>
>> >> config ACPI_PCI
>> >> bool
>> >> depends on ACPI && PCI
>> >>
>> >
>> >
>>
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-20 0:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-17 0:51 [Qemu-devel] [PATCH] hw/acpi: ACPI_PCI should depends on both ACPI and PCI Wei Yang
2019-05-17 1:44 ` Richard Henderson
2019-05-17 11:11 ` Igor Mammedov
2019-05-17 12:59 ` Wei Yang
2019-05-17 14:29 ` Igor Mammedov
2019-05-20 0:35 ` Wei Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).