Re: [Qemu-devel] [PATCH v2 2/2] virtfs: Fix documentation of -fsdev and -virtfs

[Greg Kurz <groug@kaod.org>]

On Fri, 17 May 2019 15:22:48 +0200
Thomas Huth <thuth@redhat.com> wrote:

> On 17/05/2019 15.17, Greg Kurz wrote:
> > On Mon, 13 May 2019 12:34:10 +0200
> > Greg Kurz <groug@kaod.org> wrote:
> >   
> >> This fixes several things:
> >> - add "id" description to -virtfs documentation
> >> - split the description into several lines in both usage and documentation
> >>   for accurateness and clarity
> >> - add documentation and usage of the synth fsdriver
> >> - add "throttling.*" description to -fsdev local
> >> - add some missing periods
> >> - add proper reference to the virtfs-proxy-helper(1) manual page
> >> - document that the virtio device may be either virtio-9p-pci, virtio-9p-ccw
> >>   or virtio-9p-device, depending on the machine type
> >>
> >> Buglink: https://bugs.launchpad.net/qemu/+bug/1581976
> >> Signed-off-by: Greg Kurz <groug@kaod.org>
> >> ---
> >> v2: - mention virtfs-proxy-helper(1) change in the changelog
> >>     - mention virtio-9p-ccw and virtio-9p-device
> >> ---  
> > 
> > Thomas,
> > 
> > Unless you (or anyone else) have some objections, I intend to apply this patch
> > and issue a pull request in a near future.  
> 
> Fine for me - I just lack the detailed 9p knowledge to provide a real
> "Reviewed-by" here, I hope you were not waiting for it?

Heh, no pb, I wasn't expecting a detailed review.

> ... but if it
> helps, I can at least say:
> 
> Acked-by: Thomas Huth <thuth@redhat.com>

Works for me :)

Thanks Thomas !

--
Greg