From: Jan Bobek <jan.bobek@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Jan Bobek" <jan.bobek@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>
Subject: [Qemu-devel] [RISU v2 06/11] risu_i386: remove old unused code
Date: Fri, 17 May 2019 18:44:45 -0400 [thread overview]
Message-ID: <20190517224450.15566-7-jan.bobek@gmail.com> (raw)
In-Reply-To: <20190517224450.15566-1-jan.bobek@gmail.com>
The code being removed is a remnant of the past implementation; it has
since been replaced by its more powerful, architecture-independent
counterpart in reginfo.c.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Jan Bobek <jan.bobek@gmail.com>
---
risu_i386.c | 58 -----------------------------------------------------
1 file changed, 58 deletions(-)
diff --git a/risu_i386.c b/risu_i386.c
index 06d95e5..9962b8f 100644
--- a/risu_i386.c
+++ b/risu_i386.c
@@ -16,13 +16,6 @@
#include "risu.h"
#include "risu_reginfo_i386.h"
-struct reginfo master_ri, apprentice_ri;
-
-static int insn_is_ud2(uint32_t insn)
-{
- return ((insn & 0xffff) == 0x0b0f);
-}
-
void advance_pc(void *vuc)
{
ucontext_t *uc = (ucontext_t *) vuc;
@@ -57,54 +50,3 @@ uintptr_t get_pc(struct reginfo *ri)
{
return ri->gregs[REG_E(IP)];
}
-
-int send_register_info(int sock, void *uc)
-{
- struct reginfo ri;
- fill_reginfo(&ri, uc);
- return send_data_pkt(sock, &ri, sizeof(ri));
-}
-
-/* Read register info from the socket and compare it with that from the
- * ucontext. Return 0 for match, 1 for end-of-test, 2 for mismatch.
- * NB: called from a signal handler.
- */
-int recv_and_compare_register_info(int sock, void *uc)
-{
- int resp;
- fill_reginfo(&master_ri, uc);
- recv_data_pkt(sock, &apprentice_ri, sizeof(apprentice_ri));
- if (memcmp(&master_ri, &apprentice_ri, sizeof(master_ri)) != 0) {
- /* mismatch */
- resp = 2;
- } else if (insn_is_ud2(master_ri.faulting_insn)) {
- /* end of test */
- resp = 1;
- } else {
- /* either successful match or expected undef */
- resp = 0;
- }
- send_response_byte(sock, resp);
- return resp;
-}
-
-/* Print a useful report on the status of the last comparison
- * done in recv_and_compare_register_info(). This is called on
- * exit, so need not restrict itself to signal-safe functions.
- * Should return 0 if it was a good match (ie end of test)
- * and 1 for a mismatch.
- */
-int report_match_status(void)
-{
- fprintf(stderr, "match status...\n");
- fprintf(stderr, "master reginfo:\n");
- dump_reginfo(&master_ri);
- fprintf(stderr, "apprentice reginfo:\n");
- dump_reginfo(&apprentice_ri);
- if (memcmp(&master_ri, &apprentice_ri, sizeof(master_ri)) == 0) {
- fprintf(stderr, "match!\n");
- return 0;
- }
- fprintf(stderr, "mismatch!\n");
- return 1;
-}
--
2.20.1
next prev parent reply other threads:[~2019-05-17 22:50 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 22:44 [Qemu-devel] [RISU v2 00/11] Support for i386/x86_64 with vector extensions Jan Bobek
2019-05-17 22:44 ` [Qemu-devel] [RISU v2 01/11] Makefile: undefine the arch name symbol Jan Bobek
2019-05-18 15:26 ` Richard Henderson
2019-05-20 11:47 ` Alex Bennée
2019-05-17 22:44 ` [Qemu-devel] [RISU v2 02/11] risu_i386: move reginfo_t and related defines to risu_reginfo_i386.h Jan Bobek
2019-05-18 15:27 ` Richard Henderson
2019-05-17 22:44 ` [Qemu-devel] [RISU v2 03/11] risu_i386: move reginfo-related code to risu_reginfo_i386.c Jan Bobek
2019-05-18 15:27 ` Richard Henderson
2019-05-17 22:44 ` [Qemu-devel] [RISU v2 04/11] risu_reginfo_i386: implement arch-specific reginfo interface Jan Bobek
2019-05-18 15:31 ` Richard Henderson
2019-05-20 12:11 ` Alex Bennée
2019-05-17 22:44 ` [Qemu-devel] [RISU v2 05/11] risu_i386: implement missing CPU-specific functions Jan Bobek
2019-05-18 15:34 ` Richard Henderson
2019-05-20 12:12 ` Alex Bennée
2019-05-17 22:44 ` Jan Bobek [this message]
2019-05-18 15:35 ` [Qemu-devel] [RISU v2 06/11] risu_i386: remove old unused code Richard Henderson
2019-05-17 22:44 ` [Qemu-devel] [RISU v2 07/11] test_i386: change syntax from nasm to gas Jan Bobek
2019-05-18 15:37 ` Richard Henderson
2019-05-20 12:17 ` Alex Bennée
2019-05-20 22:43 ` Richard Henderson
2019-05-21 9:08 ` Alex Bennée
2019-05-21 13:32 ` Richard Henderson
2019-05-21 15:30 ` Alex Bennée
2019-05-21 16:48 ` Jan Bobek
2019-05-21 16:56 ` Richard Henderson
2019-05-21 17:07 ` Jan Bobek
2019-05-17 22:44 ` [Qemu-devel] [RISU v2 08/11] configure: add i386/x86_64 architectures Jan Bobek
2019-05-18 15:37 ` Richard Henderson
2019-05-20 12:17 ` Alex Bennée
2019-05-17 22:44 ` [Qemu-devel] [RISU v2 09/11] i386: Add avx512 state to reginfo_t Jan Bobek
2019-05-17 22:44 ` [Qemu-devel] [RISU v2 10/11] risu_reginfo_i386: replace xfeature constants with symbolic names Jan Bobek
2019-05-18 15:59 ` Richard Henderson
2019-05-20 12:18 ` Alex Bennée
2019-05-17 22:44 ` [Qemu-devel] [RISU v2 11/11] risu_reginfo_i386: accept named feature sets for --xfeature Jan Bobek
2019-05-18 16:00 ` Richard Henderson
2019-05-18 12:23 ` [Qemu-devel] [RISU v2 00/11] Support for i386/x86_64 with vector extensions Alex Bennée
2019-05-20 12:30 ` Alex Bennée
2019-05-21 15:28 ` Jan Bobek
2019-05-21 16:49 ` Richard Henderson
2019-05-23 18:03 ` Jan Bobek
2019-05-23 18:29 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190517224450.15566-7-jan.bobek@gmail.com \
--to=jan.bobek@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).