From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9200CC04AAF for ; Sat, 18 May 2019 14:21:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66A3F20675 for ; Sat, 18 May 2019 14:21:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66A3F20675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:34800 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hS0D8-0001xO-Lc for qemu-devel@archiver.kernel.org; Sat, 18 May 2019 10:21:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hS0CH-0001Si-Jj for qemu-devel@nongnu.org; Sat, 18 May 2019 10:20:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hS0CG-0006v4-KN for qemu-devel@nongnu.org; Sat, 18 May 2019 10:20:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45978) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hS0CG-0006uB-Ea; Sat, 18 May 2019 10:20:24 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ABC453082E4E; Sat, 18 May 2019 14:20:23 +0000 (UTC) Received: from x1.home (ovpn-117-92.phx2.redhat.com [10.3.117.92]) by smtp.corp.redhat.com (Postfix) with ESMTP id 349A3183C4; Sat, 18 May 2019 14:20:21 +0000 (UTC) Date: Sat, 18 May 2019 08:20:20 -0600 From: Alex Williamson To: Li Qiang Message-ID: <20190518082020.6b223ab0@x1.home> In-Reply-To: <20190518032811.60341-2-liq3ea@163.com> References: <20190518032811.60341-1-liq3ea@163.com> <20190518032811.60341-2-liq3ea@163.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Sat, 18 May 2019 14:20:23 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 2/4] hw: vfio: drop TYPE_FOO MACRO in VMStateDescription X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, qemu-trivial@nongnu.org, liq3ea@gmail.com, qemu-devel@nongnu.org, philmd@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 17 May 2019 20:28:09 -0700 Li Qiang wrote: > As the vmstate structure names aren't related with > the QOM type names. Seems contrary to the first patch in the series. > CC: qemu-trivial@nongnu.org > Signed-off-by: Li Qiang > --- > hw/vfio/amd-xgbe.c | 2 +- > hw/vfio/ap.c | 2 +- > hw/vfio/calxeda-xgmac.c | 2 +- > hw/vfio/ccw.c | 2 +- > hw/vfio/platform.c | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/hw/vfio/amd-xgbe.c b/hw/vfio/amd-xgbe.c > index ee64a3b4a2..1b06c0f3ea 100644 > --- a/hw/vfio/amd-xgbe.c > +++ b/hw/vfio/amd-xgbe.c > @@ -26,7 +26,7 @@ static void amd_xgbe_realize(DeviceState *dev, Error **errp) > } > > static const VMStateDescription vfio_platform_amd_xgbe_vmstate = { > - .name = TYPE_VFIO_AMD_XGBE, > + .name = "vfio-amd-xgbe", > .unmigratable = 1, > }; > > diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c > index d8b79ebe53..564751650f 100644 > --- a/hw/vfio/ap.c > +++ b/hw/vfio/ap.c > @@ -155,7 +155,7 @@ static void vfio_ap_reset(DeviceState *dev) > } > > static const VMStateDescription vfio_ap_vmstate = { > - .name = VFIO_AP_DEVICE_TYPE, > + .name = "vfio-ap", > .unmigratable = 1, > }; > > diff --git a/hw/vfio/calxeda-xgmac.c b/hw/vfio/calxeda-xgmac.c > index e7767c4b02..6cc608b6ca 100644 > --- a/hw/vfio/calxeda-xgmac.c > +++ b/hw/vfio/calxeda-xgmac.c > @@ -26,7 +26,7 @@ static void calxeda_xgmac_realize(DeviceState *dev, Error **errp) > } > > static const VMStateDescription vfio_platform_calxeda_xgmac_vmstate = { > - .name = TYPE_VFIO_CALXEDA_XGMAC, > + .name = "vfio-calxeda-xgmac", > .unmigratable = 1, > }; > > diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c > index 31dd3a2a87..d9e39552e2 100644 > --- a/hw/vfio/ccw.c > +++ b/hw/vfio/ccw.c > @@ -468,7 +468,7 @@ static Property vfio_ccw_properties[] = { > }; > > static const VMStateDescription vfio_ccw_vmstate = { > - .name = TYPE_VFIO_CCW, > + .name = "vfio-ccw", > .unmigratable = 1, > }; > > diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c > index 398db38f14..e59a0234dd 100644 > --- a/hw/vfio/platform.c > +++ b/hw/vfio/platform.c > @@ -697,7 +697,7 @@ out: > } > > static const VMStateDescription vfio_platform_vmstate = { > - .name = TYPE_VFIO_PLATFORM, > + .name = "vfio-platform", > .unmigratable = 1, > }; >