From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BABEC04AAF for ; Sat, 18 May 2019 14:23:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 119BA2087B for ; Sat, 18 May 2019 14:23:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 119BA2087B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:34813 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hS0F0-0003Cx-Ba for qemu-devel@archiver.kernel.org; Sat, 18 May 2019 10:23:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hS0Do-0002XY-Bn for qemu-devel@nongnu.org; Sat, 18 May 2019 10:22:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hS0Dn-0007a1-Fh for qemu-devel@nongnu.org; Sat, 18 May 2019 10:22:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36338) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hS0Dn-0007Zh-9p; Sat, 18 May 2019 10:21:59 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A146B307D91F; Sat, 18 May 2019 14:21:58 +0000 (UTC) Received: from x1.home (ovpn-117-92.phx2.redhat.com [10.3.117.92]) by smtp.corp.redhat.com (Postfix) with ESMTP id F222A5D9D6; Sat, 18 May 2019 14:21:55 +0000 (UTC) Date: Sat, 18 May 2019 08:21:55 -0600 From: Alex Williamson To: Li Qiang Message-ID: <20190518082155.213cc6d0@x1.home> In-Reply-To: <20190518032811.60341-4-liq3ea@163.com> References: <20190518032811.60341-1-liq3ea@163.com> <20190518032811.60341-4-liq3ea@163.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Sat, 18 May 2019 14:21:58 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 4/4] pci: msix: move 'MSIX_CAP_LENGTH' to header file X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, qemu-trivial@nongnu.org, liq3ea@gmail.com, qemu-devel@nongnu.org, philmd@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 17 May 2019 20:28:11 -0700 Li Qiang wrote: Lacking commit message. > CC: qemu-trivial@nongnu.org > Signed-off-by: Li Qiang > --- > hw/pci/msix.c | 2 -- > hw/vfio/pci.c | 2 -- > include/hw/pci/msix.h | 2 ++ > 3 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/hw/pci/msix.c b/hw/pci/msix.c > index 4e336416a7..d39dcf32e8 100644 > --- a/hw/pci/msix.c > +++ b/hw/pci/msix.c > @@ -24,8 +24,6 @@ > #include "qapi/error.h" > #include "trace.h" > > -#define MSIX_CAP_LENGTH 12 > - > /* MSI enable bit and maskall bit are in byte 1 in FLAGS register */ > #define MSIX_CONTROL_OFFSET (PCI_MSIX_FLAGS + 1) > #define MSIX_ENABLE_MASK (PCI_MSIX_FLAGS_ENABLE >> 8) > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index 08729e5875..8e555db12e 100644 > --- a/hw/vfio/pci.c > +++ b/hw/vfio/pci.c > @@ -35,8 +35,6 @@ > #include "trace.h" > #include "qapi/error.h" > > -#define MSIX_CAP_LENGTH 12 > - > #define TYPE_VFIO_PCI "vfio-pci" > #define PCI_VFIO(obj) OBJECT_CHECK(VFIOPCIDevice, obj, TYPE_VFIO_PCI) > > diff --git a/include/hw/pci/msix.h b/include/hw/pci/msix.h > index 1f27658d35..08acfa836e 100644 > --- a/include/hw/pci/msix.h > +++ b/include/hw/pci/msix.h > @@ -4,6 +4,8 @@ > #include "qemu-common.h" > #include "hw/pci/pci.h" > > +#define MSIX_CAP_LENGTH 12 > + > void msix_set_message(PCIDevice *dev, int vector, MSIMessage msg); > MSIMessage msix_get_message(PCIDevice *dev, unsigned int vector); > int msix_init(PCIDevice *dev, unsigned short nentries,