qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	peterx@redhat.com, Juan Quintela <quintela@redhat.com>
Subject: [Qemu-devel] [PATCH v2 13/15] qmp: Expose manual_dirty_log_protect via "query-kvm"
Date: Mon, 20 May 2019 11:08:37 +0800	[thread overview]
Message-ID: <20190520030839.6795-14-peterx@redhat.com> (raw)
In-Reply-To: <20190520030839.6795-1-peterx@redhat.com>

Expose the new capability via "query-kvm" QMP command too so we know
whether that's turned on on the source VM when we want.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 accel/kvm/kvm-all.c  | 5 +++++
 include/sysemu/kvm.h | 2 ++
 qapi/misc.json       | 6 +++++-
 qmp.c                | 1 +
 4 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index 062bf8b5b0..c79d6b51e2 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -169,6 +169,11 @@ int kvm_memcrypt_encrypt_data(uint8_t *ptr, uint64_t len)
     return 1;
 }
 
+bool kvm_manual_dirty_log_protect_enabled(void)
+{
+    return kvm_state && kvm_state->manual_dirty_log_protect;
+}
+
 /* Must be with slots_lock held */
 static KVMSlot *kvm_get_free_slot(KVMMemoryListener *kml)
 {
diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
index a6d1cd190f..30757f1425 100644
--- a/include/sysemu/kvm.h
+++ b/include/sysemu/kvm.h
@@ -547,4 +547,6 @@ int kvm_set_one_reg(CPUState *cs, uint64_t id, void *source);
 int kvm_get_one_reg(CPUState *cs, uint64_t id, void *target);
 struct ppc_radix_page_info *kvm_get_radix_page_info(void);
 int kvm_get_max_memslots(void);
+bool kvm_manual_dirty_log_protect_enabled(void);
+
 #endif
diff --git a/qapi/misc.json b/qapi/misc.json
index 8b3ca4fdd3..ce7a76755a 100644
--- a/qapi/misc.json
+++ b/qapi/misc.json
@@ -253,9 +253,13 @@
 #
 # @present: true if KVM acceleration is built into this executable
 #
+# @manual-dirty-log-protect: true if manual dirty log protect is enabled
+#
 # Since: 0.14.0
 ##
-{ 'struct': 'KvmInfo', 'data': {'enabled': 'bool', 'present': 'bool'} }
+{ 'struct': 'KvmInfo', 'data':
+  {'enabled': 'bool', 'present': 'bool',
+   'manual-dirty-log-protect': 'bool' } }
 
 ##
 # @query-kvm:
diff --git a/qmp.c b/qmp.c
index b92d62cd5f..047bef032e 100644
--- a/qmp.c
+++ b/qmp.c
@@ -73,6 +73,7 @@ KvmInfo *qmp_query_kvm(Error **errp)
 
     info->enabled = kvm_enabled();
     info->present = kvm_available();
+    info->manual_dirty_log_protect = kvm_manual_dirty_log_protect_enabled();
 
     return info;
 }
-- 
2.17.1



  parent reply	other threads:[~2019-05-20  3:22 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20  3:08 [Qemu-devel] [PATCH v2 00/15] kvm/migration: support KVM_CLEAR_DIRTY_LOG Peter Xu
2019-05-20  3:08 ` [Qemu-devel] [PATCH v2 01/15] checkpatch: Allow SPDX-License-Identifier Peter Xu
2019-05-20  3:08 ` [Qemu-devel] [PATCH v2 02/15] linux-headers: Update to Linux 5.2-rc1 Peter Xu
2019-05-20  3:08 ` [Qemu-devel] [PATCH v2 03/15] migration: No need to take rcu during sync_dirty_bitmap Peter Xu
2019-05-20 10:48   ` Paolo Bonzini
2019-05-21  2:28     ` Peter Xu
2019-05-20  3:08 ` [Qemu-devel] [PATCH v2 04/15] memory: Remove memory_region_get_dirty() Peter Xu
2019-05-20  3:08 ` [Qemu-devel] [PATCH v2 05/15] memory: Don't set migration bitmap when without migration Peter Xu
2019-05-20  3:08 ` [Qemu-devel] [PATCH v2 06/15] bitmap: Add bitmap_copy_with_{src|dst}_offset() Peter Xu
2019-05-20  3:08 ` [Qemu-devel] [PATCH v2 07/15] memory: Pass mr into snapshot_and_clear_dirty Peter Xu
2019-05-20  3:08 ` [Qemu-devel] [PATCH v2 08/15] memory: Introduce memory listener hook log_clear() Peter Xu
2019-05-20  3:08 ` [Qemu-devel] [PATCH v2 09/15] kvm: Update comments for sync_dirty_bitmap Peter Xu
2019-05-20  3:08 ` [Qemu-devel] [PATCH v2 10/15] kvm: Persistent per kvmslot dirty bitmap Peter Xu
2019-05-20  3:08 ` [Qemu-devel] [PATCH v2 11/15] kvm: Introduce slots lock for memory listener Peter Xu
2019-05-20 10:49   ` Paolo Bonzini
2019-05-21  2:34     ` Peter Xu
2019-05-20  3:08 ` [Qemu-devel] [PATCH v2 12/15] kvm: Support KVM_CLEAR_DIRTY_LOG Peter Xu
2019-05-20 10:50   ` Paolo Bonzini
2019-05-21  2:38     ` Peter Xu
2019-05-20  3:08 ` Peter Xu [this message]
2019-05-20 10:44   ` [Qemu-devel] [PATCH v2 13/15] qmp: Expose manual_dirty_log_protect via "query-kvm" Paolo Bonzini
2019-05-20 16:37     ` Dr. David Alan Gilbert
2019-05-21  1:15     ` Peter Xu
2019-05-20 16:30   ` Eric Blake
2019-05-21  2:42     ` Peter Xu
2019-05-20  3:08 ` [Qemu-devel] [PATCH v2 14/15] hmp: Expose manual_dirty_log_protect via "info kvm" Peter Xu
2019-05-20 10:44   ` Paolo Bonzini
2019-05-20  3:08 ` [Qemu-devel] [PATCH v2 15/15] migration: Split log_clear() into smaller chunks Peter Xu
2019-05-20 10:47 ` [Qemu-devel] [PATCH v2 00/15] kvm/migration: support KVM_CLEAR_DIRTY_LOG Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190520030839.6795-14-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).