From: David Gibson <david@gibson.dropbear.id.au>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: mark.cave-ayland@ilande.co.uk, qemu-ppc@nongnu.org,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] target/ppc: make use of new gvec expanders
Date: Mon, 20 May 2019 15:56:31 +1000 [thread overview]
Message-ID: <20190520055630.GA20828@umbus.fritz.box> (raw)
In-Reply-To: <20190520040142.GA27407@umbus.fritz.box>
[-- Attachment #1: Type: text/plain, Size: 1888 bytes --]
On Mon, May 20, 2019 at 02:01:42PM +1000, David Gibson wrote:
> On Sat, May 18, 2019 at 12:14:28PM -0700, Richard Henderson wrote:
> > Based-on: <20190518190157.21255-1-richard.henderson@linaro.org>
> > Aka "tcg: misc gvec improvements".
> >
> > Since Mark's initial patches, we've added (or are adding)
> > generic support for variable vector shifts and bitsel.
>
> Applied, thanks.
Urgh.. actually, I've removed 2/2 again. I get this error:
In file included from /home/dwg/src/qemu/target/ppc/translate.c:6819:
/home/dwg/src/qemu/target/ppc/translate/vsx-impl.inc.c: In function ‘gen_xxsel’:
/home/dwg/src/qemu/target/ppc/translate/vsx-impl.inc.c:1352:5: error: implicit declaration of function ‘tcg_gen_gvec_bitsel’; did you mean ‘tcg_gen_gvec_2i_ool’? [-Werror=implicit-function-declaration]
1352 | tcg_gen_gvec_bitsel(MO_64, vsr_full_offset(rt), vsr_full_offset(rc),
| ^~~~~~~~~~~~~~~~~~~
| tcg_gen_gvec_2i_ool
/home/dwg/src/qemu/target/ppc/translate/vsx-impl.inc.c:1352:5: error: nested extern declaration of ‘tcg_gen_gvec_bitsel’ [-Werror=nested-externs]
cc1: all warnings being treated as errors
>
> >
> >
> > r~
> >
> >
> > Richard Henderson (2):
> > target/ppc: Use vector variable shifts for VSL, VSR, VSRA
> > target/ppc: Use tcg_gen_gvec_bitsel
> >
> > target/ppc/helper.h | 12 ----------
> > target/ppc/int_helper.c | 37 -----------------------------
> > target/ppc/translate/vmx-impl.inc.c | 24 +++++++++----------
> > target/ppc/translate/vsx-impl.inc.c | 24 ++-----------------
> > 4 files changed, 14 insertions(+), 83 deletions(-)
> >
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-05-20 6:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-18 19:14 [Qemu-devel] [PATCH 0/2] target/ppc: make use of new gvec expanders Richard Henderson
2019-05-18 19:14 ` [Qemu-devel] [PATCH 1/2] target/ppc: Use vector variable shifts for VSL, VSR, VSRA Richard Henderson
2019-05-20 6:49 ` Aleksandar Markovic
2019-05-21 2:03 ` Richard Henderson
2019-05-18 19:14 ` [Qemu-devel] [PATCH 2/2] target/ppc: Use tcg_gen_gvec_bitsel Richard Henderson
2019-05-20 4:01 ` [Qemu-devel] [PATCH 0/2] target/ppc: make use of new gvec expanders David Gibson
2019-05-20 5:56 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520055630.GA20828@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).