From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93EC2C04AAF for ; Mon, 20 May 2019 06:34:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 62EFC20851 for ; Mon, 20 May 2019 06:34:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.b="I19Ial1f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62EFC20851 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:58826 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSbsC-0004aa-MC for qemu-devel@archiver.kernel.org; Mon, 20 May 2019 02:34:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50870) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSbqe-0003qp-GY for qemu-devel@nongnu.org; Mon, 20 May 2019 02:32:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSbqd-00006z-EG for qemu-devel@nongnu.org; Mon, 20 May 2019 02:32:36 -0400 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:56241 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hSbqb-0008Vd-Fr; Mon, 20 May 2019 02:32:33 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 456pwV39hhz9s9y; Mon, 20 May 2019 16:32:22 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1558333946; bh=FBPmBMesoFb4P+TklX5wAjJ13tGtE/uCElvtj7DwCBo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I19Ial1fiB5Ecjl9S+054hxsoQaY8nwzSiba1jxYie43C1G3qBvgMsO4uNuJLqrtr fVE+vEtKoQEa4QumyJbtSPxTFOqo63pqZNAzNH09RN0nJoao+bp1/5+afc86EyyGTy CiZzLwobGW2Vr4edJEsC9YFzbqKDlhYhPprG6cX8= Date: Mon, 20 May 2019 16:21:37 +1000 From: David Gibson To: Greg Kurz Message-ID: <20190520062137.GD27407@umbus.fritz.box> References: <155799221739.527449.14907564571096243745.stgit@bahia.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="veXX9dWIonWZEC6h" Content-Disposition: inline In-Reply-To: <155799221739.527449.14907564571096243745.stgit@bahia.lan> User-Agent: Mutt/1.11.4 (2019-03-13) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: Re: [Qemu-devel] [PATCH] spapr: Print out extra hints when CAS negotiation of interrupt mode fails X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Satheesh Rajendran , qemu-ppc@nongnu.org, =?iso-8859-1?Q?C=E9dric?= Le Goater , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --veXX9dWIonWZEC6h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 16, 2019 at 09:36:57AM +0200, Greg Kurz wrote: > Let's suggest to the user how the machine should be configured to allow > the guest to boot successfully. >=20 > Suggested-by: Satheesh Rajendran > Signed-off-by: Greg Kurz Applied, thanks. > --- > hw/ppc/spapr_hcall.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c > index 63a55614b83d..aae9fd2b3e6d 100644 > --- a/hw/ppc/spapr_hcall.c > +++ b/hw/ppc/spapr_hcall.c > @@ -1646,12 +1646,12 @@ static target_ulong h_client_architecture_support= (PowerPCCPU *cpu, > */ > if (guest_xive) { > if (spapr->irq->ov5 =3D=3D SPAPR_OV5_XIVE_LEGACY) { > - error_report("Guest requested unavailable interrupt mode (XI= VE)"); > + error_report("Guest requested unavailable interrupt mode (XI= VE), try the ic-mode=3Dxive or ic-mode=3Ddual machine property"); > exit(EXIT_FAILURE); > } > } else { > if (spapr->irq->ov5 =3D=3D SPAPR_OV5_XIVE_EXPLOIT) { > - error_report("Guest requested unavailable interrupt mode (XI= CS)"); > + error_report("Guest requested unavailable interrupt mode (XI= CS), either don't set the ic-mode machine property or try ic-mode=3Dxics or= ic-mode=3Ddual"); > exit(EXIT_FAILURE); > } > } >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --veXX9dWIonWZEC6h Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAlziR3EACgkQbDjKyiDZ s5L6Cw/9Eh2mNmhCDYVmNN2bkglHGBz9B5p98rBU0ATxuxdYo3NxGdpLdmRGEhNg HbMn94JXtS48fTnAwu4E+TrlOVHyriB4kb/OFWAecRosn7f0ObE7AgsK/p2Au72x CcK1q9wGcCWv/Y9EXlDNE/n6+TpUSQM3z1sEgR3WxVoIIEc0IeY6Jvlc+KOToi9E tZjkmboZAtL9I1RgDHBzz06lO1G1HORCKtxlexqJZuQVCbiHHWINnqAPmZLPkSai hEODOobtkPKkgZKBNywuPb7kkpnBWK6hnsoaUjtakUL3RZddqzNTFbL6DKJX9nlQ y7SWGvwv3iEjeXlFDlr7EXiw/1ASFf3L7Ys3cBAAftOhxhL5zBlHyHAnlDwrSEAx zXl9ILeFXQAc26TsrMOtarNSAxjYRKU6SzjkcqGPMnQKEe/v3VdjYv4jzpfYIDf/ IgKrqcyHxWJonmYw3vV+gxAy2Gfhy3N0gneI9ntBTxTRYArb1+tjwEhx1PUqfdX9 poD+eh5dlaDe21TWJWTTulesrmQv5d/85iP1w9WJh9+NAofj9f39VBog142WfEHp Gmgq4YmgnF7E31NOhk0xsEbqOWD6UUcZV5uLhzmLovod2OnRdF2+BCrThsICbB++ yVwPlXJjt9ZZfh1WnGTbMMsfzGjwEWxCULi/Eae9XmRhZegc7+4= =akih -----END PGP SIGNATURE----- --veXX9dWIonWZEC6h--