From: Keith Busch <kbusch@kernel.org>
To: Klaus Birkelund Jensen <klaus@birkelund.eu>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, "Heitke,
Kenneth" <kenneth.heitke@intel.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Keith Busch <keith.busch@intel.com>
Subject: Re: [Qemu-devel] [PATCH] nvme: fix copy direction in DMA reads going to CMB
Date: Mon, 20 May 2019 09:05:57 -0600 [thread overview]
Message-ID: <20190520150557.GE25092@localhost.localdomain> (raw)
In-Reply-To: <20190518073905.17178-1-klaus@birkelund.eu>
On Sat, May 18, 2019 at 09:39:05AM +0200, Klaus Birkelund Jensen wrote:
> `nvme_dma_read_prp` erronously used `qemu_iovec_*to*_buf` instead of
> `qemu_iovec_*from*_buf` when the request involved the controller memory
> buffer.
>
> Signed-off-by: Klaus Birkelund Jensen <klaus.jensen@cnexlabs.com>
I was wondering how this mistake got by for so long, and it looks like
the only paths here require an admin command with dev->host transfer
to CMB. That's just not done in any host implementation I'm aware of
since it'd make it more difficult to use for no particular gain AFAICS,
so I'd be curious to hear if you have a legit implementation doing this.
Anyway, thanks for the fix.
next prev parent reply other threads:[~2019-05-20 17:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-18 7:39 [Qemu-devel] [PATCH] nvme: fix copy direction in DMA reads going to CMB Klaus Birkelund Jensen
2019-05-18 17:56 ` Heitke, Kenneth
2019-05-20 10:11 ` Kevin Wolf
2019-05-20 15:05 ` Keith Busch [this message]
2019-05-20 17:56 ` Klaus Birkelund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520150557.GE25092@localhost.localdomain \
--to=kbusch@kernel.org \
--cc=keith.busch@intel.com \
--cc=kenneth.heitke@intel.com \
--cc=klaus@birkelund.eu \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).