From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 06/24] nvme: fix copy direction in DMA reads going to CMB
Date: Mon, 20 May 2019 18:14:35 +0200 [thread overview]
Message-ID: <20190520161453.30723-7-kwolf@redhat.com> (raw)
In-Reply-To: <20190520161453.30723-1-kwolf@redhat.com>
From: Klaus Birkelund Jensen <klaus@birkelund.eu>
`nvme_dma_read_prp` erronously used `qemu_iovec_*to*_buf` instead of
`qemu_iovec_*from*_buf` when the request involved the controller memory
buffer.
Signed-off-by: Klaus Birkelund Jensen <klaus.jensen@cnexlabs.com>
Reviewed-by: Kenneth Heitke <kenneth.heitke@intel.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
hw/block/nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 7caf92532a..63a5b58849 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -238,7 +238,7 @@ static uint16_t nvme_dma_read_prp(NvmeCtrl *n, uint8_t *ptr, uint32_t len,
}
qemu_sglist_destroy(&qsg);
} else {
- if (unlikely(qemu_iovec_to_buf(&iov, 0, ptr, len) != len)) {
+ if (unlikely(qemu_iovec_from_buf(&iov, 0, ptr, len) != len)) {
trace_nvme_err_invalid_dma();
status = NVME_INVALID_FIELD | NVME_DNR;
}
--
2.20.1
next prev parent reply other threads:[~2019-05-20 16:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 16:14 [Qemu-devel] [PULL 00/24] Block layer patches Kevin Wolf
2019-05-20 16:14 ` [Qemu-devel] [PULL 01/24] block/file-posix: Truncate in xfs_write_zeroes() Kevin Wolf
2019-05-20 16:14 ` [Qemu-devel] [PULL 02/24] qcow2: Define and use QCOW2_COMPRESSED_SECTOR_SIZE Kevin Wolf
2019-05-20 16:14 ` [Qemu-devel] [PULL 03/24] block: Use BDRV_REQUEST_MAX_BYTES instead of BDRV_REQUEST_MAX_SECTORS Kevin Wolf
2019-05-20 16:14 ` [Qemu-devel] [PULL 04/24] qmp: forbid qmp_cont in RUN_STATE_FINISH_MIGRATE Kevin Wolf
2019-05-20 16:14 ` [Qemu-devel] [PULL 05/24] iotest: fix 169: do not run " Kevin Wolf
2019-05-20 16:14 ` Kevin Wolf [this message]
2019-05-20 16:14 ` [Qemu-devel] [PULL 07/24] block: Add bdrv_try_set_aio_context() Kevin Wolf
2019-05-20 16:14 ` [Qemu-devel] [PULL 08/24] block: Make bdrv_attach/detach_aio_context() static Kevin Wolf
2019-05-20 16:14 ` [Qemu-devel] [PULL 09/24] block: Move recursion to bdrv_set_aio_context() Kevin Wolf
2019-05-20 16:14 ` [Qemu-devel] [PULL 10/24] block: Propagate AioContext change to parents Kevin Wolf
2019-05-20 16:14 ` [Qemu-devel] [PULL 11/24] test-block-iothread: Test AioContext propagation through the tree Kevin Wolf
2019-05-20 16:14 ` [Qemu-devel] [PULL 12/24] block: Implement .(can_)set_aio_ctx for BlockBackend Kevin Wolf
2019-05-20 16:14 ` [Qemu-devel] [PULL 13/24] block: Add blk_set_allow_aio_context_change() Kevin Wolf
2019-05-20 16:14 ` [Qemu-devel] [PULL 14/24] blockjob: Propagate AioContext change to all job nodes Kevin Wolf
2019-05-20 16:14 ` [Qemu-devel] [PULL 15/24] blockjob: Remove AioContext notifiers Kevin Wolf
2019-05-20 16:14 ` [Qemu-devel] [PULL 16/24] test-block-iothread: Test AioContext propagation for block jobs Kevin Wolf
2019-05-20 16:14 ` [Qemu-devel] [PULL 17/24] block/file-posix: Unaligned O_DIRECT block-status Kevin Wolf
2019-05-20 16:14 ` [Qemu-devel] [PULL 18/24] iotests: Test unaligned raw images with O_DIRECT Kevin Wolf
2019-05-20 16:14 ` [Qemu-devel] [PULL 19/24] qemu-img.texi: Be specific about JSON object types Kevin Wolf
2019-05-20 16:14 ` [Qemu-devel] [PULL 20/24] qemu-img.texi: Describe human-readable info output Kevin Wolf
2019-05-20 16:14 ` [Qemu-devel] [PULL 21/24] block: Improve "Block node is read-only" message Kevin Wolf
2019-05-20 16:14 ` [Qemu-devel] [PULL 22/24] iotests.py: Let assert_qmp() accept an array Kevin Wolf
2019-05-20 16:14 ` [Qemu-devel] [PULL 23/24] iotests.py: Fix VM.run_job Kevin Wolf
2019-05-20 16:14 ` [Qemu-devel] [PULL 24/24] iotests: Make 245 faster and more reliable Kevin Wolf
2019-05-20 17:08 ` [Qemu-devel] [PULL 00/24] Block layer patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520161453.30723-7-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).