From: Peter Xu <peterx@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
qemu-devel@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 11/15] kvm: Introduce slots lock for memory listener
Date: Tue, 21 May 2019 10:34:32 +0800 [thread overview]
Message-ID: <20190521023432.GR16681@xz-x1> (raw)
In-Reply-To: <33678ffc-8556-5cb8-f29e-907cf031a50b@redhat.com>
On Mon, May 20, 2019 at 12:49:39PM +0200, Paolo Bonzini wrote:
> On 20/05/19 05:08, Peter Xu wrote:
> > +/* Must be with slots_lock held */
>
> Perhaps "Called with KVMMemoryListener slots_lock held."?
Yes sounds better. I'm replacing the old comments with "Called with
KVMMemoryListener.slots_lock held" (with the dot).
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2019-05-21 2:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 3:08 [Qemu-devel] [PATCH v2 00/15] kvm/migration: support KVM_CLEAR_DIRTY_LOG Peter Xu
2019-05-20 3:08 ` [Qemu-devel] [PATCH v2 01/15] checkpatch: Allow SPDX-License-Identifier Peter Xu
2019-05-20 3:08 ` [Qemu-devel] [PATCH v2 02/15] linux-headers: Update to Linux 5.2-rc1 Peter Xu
2019-05-20 3:08 ` [Qemu-devel] [PATCH v2 03/15] migration: No need to take rcu during sync_dirty_bitmap Peter Xu
2019-05-20 10:48 ` Paolo Bonzini
2019-05-21 2:28 ` Peter Xu
2019-05-20 3:08 ` [Qemu-devel] [PATCH v2 04/15] memory: Remove memory_region_get_dirty() Peter Xu
2019-05-20 3:08 ` [Qemu-devel] [PATCH v2 05/15] memory: Don't set migration bitmap when without migration Peter Xu
2019-05-20 3:08 ` [Qemu-devel] [PATCH v2 06/15] bitmap: Add bitmap_copy_with_{src|dst}_offset() Peter Xu
2019-05-20 3:08 ` [Qemu-devel] [PATCH v2 07/15] memory: Pass mr into snapshot_and_clear_dirty Peter Xu
2019-05-20 3:08 ` [Qemu-devel] [PATCH v2 08/15] memory: Introduce memory listener hook log_clear() Peter Xu
2019-05-20 3:08 ` [Qemu-devel] [PATCH v2 09/15] kvm: Update comments for sync_dirty_bitmap Peter Xu
2019-05-20 3:08 ` [Qemu-devel] [PATCH v2 10/15] kvm: Persistent per kvmslot dirty bitmap Peter Xu
2019-05-20 3:08 ` [Qemu-devel] [PATCH v2 11/15] kvm: Introduce slots lock for memory listener Peter Xu
2019-05-20 10:49 ` Paolo Bonzini
2019-05-21 2:34 ` Peter Xu [this message]
2019-05-20 3:08 ` [Qemu-devel] [PATCH v2 12/15] kvm: Support KVM_CLEAR_DIRTY_LOG Peter Xu
2019-05-20 10:50 ` Paolo Bonzini
2019-05-21 2:38 ` Peter Xu
2019-05-20 3:08 ` [Qemu-devel] [PATCH v2 13/15] qmp: Expose manual_dirty_log_protect via "query-kvm" Peter Xu
2019-05-20 10:44 ` Paolo Bonzini
2019-05-20 16:37 ` Dr. David Alan Gilbert
2019-05-21 1:15 ` Peter Xu
2019-05-20 16:30 ` Eric Blake
2019-05-21 2:42 ` Peter Xu
2019-05-20 3:08 ` [Qemu-devel] [PATCH v2 14/15] hmp: Expose manual_dirty_log_protect via "info kvm" Peter Xu
2019-05-20 10:44 ` Paolo Bonzini
2019-05-20 3:08 ` [Qemu-devel] [PATCH v2 15/15] migration: Split log_clear() into smaller chunks Peter Xu
2019-05-20 10:47 ` [Qemu-devel] [PATCH v2 00/15] kvm/migration: support KVM_CLEAR_DIRTY_LOG Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521023432.GR16681@xz-x1 \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).