From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65542C04AAC for ; Tue, 21 May 2019 02:38:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34A9621743 for ; Tue, 21 May 2019 02:38:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34A9621743 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:45333 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSug2-0001yj-Ck for qemu-devel@archiver.kernel.org; Mon, 20 May 2019 22:38:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSufH-0001gm-MQ for qemu-devel@nongnu.org; Mon, 20 May 2019 22:38:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSufG-0000x0-Od for qemu-devel@nongnu.org; Mon, 20 May 2019 22:38:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54376) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hSufG-0000wn-JY for qemu-devel@nongnu.org; Mon, 20 May 2019 22:38:06 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EFE587F7C5 for ; Tue, 21 May 2019 02:38:05 +0000 (UTC) Received: from xz-x1 (dhcp-15-205.nay.redhat.com [10.66.15.205]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2117E19C5B; Tue, 21 May 2019 02:38:03 +0000 (UTC) Date: Tue, 21 May 2019 10:38:01 +0800 From: Peter Xu To: Paolo Bonzini Message-ID: <20190521023801.GS16681@xz-x1> References: <20190520030839.6795-1-peterx@redhat.com> <20190520030839.6795-13-peterx@redhat.com> <9558ee27-7d61-4afd-f4f3-ff726e8ce93d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9558ee27-7d61-4afd-f4f3-ff726e8ce93d@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 21 May 2019 02:38:05 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v2 12/15] kvm: Support KVM_CLEAR_DIRTY_LOG X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , qemu-devel@nongnu.org, "Dr . David Alan Gilbert" , Juan Quintela Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, May 20, 2019 at 12:50:24PM +0200, Paolo Bonzini wrote: > On 20/05/19 05:08, Peter Xu wrote: > > + s->manual_dirty_log_protect = > > + kvm_check_extension(s, KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2); > > + if (s->manual_dirty_log_protect) { > > + ret = kvm_vm_enable_cap(s, KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2, 0, 1); > > + if (ret) { > > + warn_report("Trying to enable KVM_CAP_MANUAL_DIRTY_LOG_PROTECT " > > Please use KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2 in the error too (and in > the commit message). Oops I did miss these, actually I also noticed some commit messages that mentioned the wrong capability name and I'll change them too (e.g., in patch 8 where the new memory API is introduced). Thanks, -- Peter Xu