From: "Michael S. Tsirkin" <mst@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: kwolf@redhat.com, thuth@redhat.com, berrange@redhat.com,
qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] docs: smbios: remove family=x from type2 entry description
Date: Tue, 21 May 2019 09:33:09 -0400 [thread overview]
Message-ID: <20190521093223-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1558444486-314511-1-git-send-email-imammedo@redhat.com>
On Tue, May 21, 2019 at 03:14:46PM +0200, Igor Mammedov wrote:
> 'family' option is not part of type 2 table and if user tries to use it
> as such QEMU will error out with an unknow option error.
> Drop it from docs lest it confuse users.
>
> Fixes: b155eb1d04
Add summary after the hash within ("...") please.
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> qemu-options.hx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 5daa5a8..dcdb808 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2080,7 +2080,7 @@ Specify SMBIOS type 0 fields
> @item -smbios type=1[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,uuid=@var{uuid}][,sku=@var{str}][,family=@var{str}]
> Specify SMBIOS type 1 fields
>
> -@item -smbios type=2[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,location=@var{str}][,family=@var{str}]
> +@item -smbios type=2[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,location=@var{str}]
> Specify SMBIOS type 2 fields
>
> @item -smbios type=3[,manufacturer=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,sku=@var{str}]
> --
> 2.7.4
prev parent reply other threads:[~2019-05-21 13:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 13:14 [Qemu-devel] [PATCH] docs: smbios: remove family=x from type2 entry description Igor Mammedov
2019-05-21 13:33 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521093223-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=imammedo@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).