From: Li Qiang <liq3ea@163.com>
To: alex.williamson@redhat.com, lvivier@redhat.com
Cc: qemu-trivial@nongnu.org, philmd@redhat.com, liq3ea@gmail.com,
qemu-devel@nongnu.org, Li Qiang <liq3ea@163.com>
Subject: [Qemu-devel] [PATCH v2 2/4] hw: vfio: drop TYPE_FOO MACRO in VMStateDescription
Date: Tue, 21 May 2019 08:15:41 -0700 [thread overview]
Message-ID: <20190521151543.92274-3-liq3ea@163.com> (raw)
In-Reply-To: <20190521151543.92274-1-liq3ea@163.com>
It's recommended that VMStateDescription names are decoupled from QOM
type names as the latter may freely change without consideration of
migration compatibility.
Link: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02175.html
CC: qemu-trivial@nongnu.org
Signed-off-by: Li Qiang <liq3ea@163.com>
---
hw/vfio/amd-xgbe.c | 2 +-
hw/vfio/ap.c | 2 +-
hw/vfio/calxeda-xgmac.c | 2 +-
hw/vfio/ccw.c | 2 +-
hw/vfio/platform.c | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/vfio/amd-xgbe.c b/hw/vfio/amd-xgbe.c
index ee64a3b4a2..1b06c0f3ea 100644
--- a/hw/vfio/amd-xgbe.c
+++ b/hw/vfio/amd-xgbe.c
@@ -26,7 +26,7 @@ static void amd_xgbe_realize(DeviceState *dev, Error **errp)
}
static const VMStateDescription vfio_platform_amd_xgbe_vmstate = {
- .name = TYPE_VFIO_AMD_XGBE,
+ .name = "vfio-amd-xgbe",
.unmigratable = 1,
};
diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
index d8b79ebe53..564751650f 100644
--- a/hw/vfio/ap.c
+++ b/hw/vfio/ap.c
@@ -155,7 +155,7 @@ static void vfio_ap_reset(DeviceState *dev)
}
static const VMStateDescription vfio_ap_vmstate = {
- .name = VFIO_AP_DEVICE_TYPE,
+ .name = "vfio-ap",
.unmigratable = 1,
};
diff --git a/hw/vfio/calxeda-xgmac.c b/hw/vfio/calxeda-xgmac.c
index e7767c4b02..6cc608b6ca 100644
--- a/hw/vfio/calxeda-xgmac.c
+++ b/hw/vfio/calxeda-xgmac.c
@@ -26,7 +26,7 @@ static void calxeda_xgmac_realize(DeviceState *dev, Error **errp)
}
static const VMStateDescription vfio_platform_calxeda_xgmac_vmstate = {
- .name = TYPE_VFIO_CALXEDA_XGMAC,
+ .name = "vfio-calxeda-xgmac",
.unmigratable = 1,
};
diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c
index 31dd3a2a87..d9e39552e2 100644
--- a/hw/vfio/ccw.c
+++ b/hw/vfio/ccw.c
@@ -468,7 +468,7 @@ static Property vfio_ccw_properties[] = {
};
static const VMStateDescription vfio_ccw_vmstate = {
- .name = TYPE_VFIO_CCW,
+ .name = "vfio-ccw",
.unmigratable = 1,
};
diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c
index 398db38f14..e59a0234dd 100644
--- a/hw/vfio/platform.c
+++ b/hw/vfio/platform.c
@@ -697,7 +697,7 @@ out:
}
static const VMStateDescription vfio_platform_vmstate = {
- .name = TYPE_VFIO_PLATFORM,
+ .name = "vfio-platform",
.unmigratable = 1,
};
--
2.17.1
next prev parent reply other threads:[~2019-05-21 15:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 15:15 [Qemu-devel] [PATCH v2 0/4] hw: vfio: some trivial fix Li Qiang
2019-05-21 15:15 ` [Qemu-devel] [PATCH v2 1/4] vfio: pci: make "vfio-pci-nohotplug" as MACRO Li Qiang
2019-05-22 15:24 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-05-21 15:15 ` Li Qiang [this message]
2019-05-22 15:26 ` [Qemu-devel] [Qemu-trivial] [PATCH v2 2/4] hw: vfio: drop TYPE_FOO MACRO in VMStateDescription Laurent Vivier
2019-05-21 15:15 ` [Qemu-devel] [PATCH v2 3/4] vfio: platform: fix a typo Li Qiang
2019-05-22 15:27 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-05-21 15:15 ` [Qemu-devel] [PATCH v2 4/4] pci: msix: move 'MSIX_CAP_LENGTH' to header file Li Qiang
2019-05-22 15:28 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-05-21 15:37 ` [Qemu-devel] [PATCH v2 0/4] hw: vfio: some trivial fix Alex Williamson
2019-05-21 15:39 ` Philippe Mathieu-Daudé
2019-05-21 15:50 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521151543.92274-3-liq3ea@163.com \
--to=liq3ea@163.com \
--cc=alex.williamson@redhat.com \
--cc=liq3ea@gmail.com \
--cc=lvivier@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).