qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PULL v3 00/55] s390x update
@ 2019-05-21 15:28 Cornelia Huck
  2019-05-21 15:28 ` [Qemu-devel] [PULL v3 46/55] update-linux-headers: handle new header file Cornelia Huck
                   ` (2 more replies)
  0 siblings, 3 replies; 20+ messages in thread
From: Cornelia Huck @ 2019-05-21 15:28 UTC (permalink / raw)
  To: Peter Maydell; +Cc: qemu-s390x, Cornelia Huck, qemu-devel

[Third time's the charm, I hope. Split out the change in the update headers
script and copy to the right directory. Sending only these two patches; the
rest are unchanged save for the commit ids.]

The following changes since commit d8276573da58e8ce78dab8c46dd660efd664bcb7:

  Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190510' into staging (2019-05-16 13:15:08 +0100)

are available in the Git repository at:

  https://github.com/cohuck/qemu tags/s390x-20190521-3

for you to fetch changes up to c657e84faee48d6ab36665da5a008b8f0649593d:

  s390x/cpumodel: wire up 8561 and 8562 as gen15 machines (2019-05-21 16:59:16 +0200)

----------------------------------------------------------------
s390x update:
- have the bios tolerate bootmap signature entries
- next chunk of vector instruction support in tcg
- a headers update against Linux 5.2-rc1
- add more facilities and gen15 machines to the cpu model

----------------------------------------------------------------

Christian Borntraeger (8):
  s390x/cpumodel: ignore csske for expansion
  s390x/cpumodel: Miscellaneous-Instruction-Extensions Facility 3
  s390x/cpumodel: msa9 facility
  s390x/cpumodel: vector enhancements
  s390x/cpumodel: enhanced sort facility
  s390x/cpumodel: add Deflate-conversion facility
  s390x/cpumodel: add gen15 defintions
  s390x/cpumodel: wire up 8561 and 8562 as gen15 machines

Cornelia Huck (4):
  s390/ipl: cast to SCSIDevice directly
  s390/css: handle CCW_FLAG_SKIP
  update-linux-headers: handle new header file
  linux headers: update against Linux 5.2-rc1

David Hildenbrand (40):
  s390x/tcg: Implement VECTOR ADD
  s390x/tcg: Implement VECTOR ADD COMPUTE CARRY
  s390x/tcg: Implement VECTOR ADD WITH CARRY
  s390x/tcg: Implement VECTOR ADD WITH CARRY COMPUTE CARRY
  s390x/tcg: Implement VECTOR AND (WITH COMPLEMENT)
  s390x/tcg: Implement VECTOR AVERAGE
  s390x/tcg: Implement VECTOR AVERAGE LOGICAL
  s390x/tcg: Implement VECTOR CHECKSUM
  s390x/tcg: Implement VECTOR ELEMENT COMPARE *
  s390x/tcg: Implement VECTOR COMPARE *
  s390x/tcg: Implement VECTOR COUNT LEADING ZEROS
  s390x/tcg: Implement VECTOR COUNT TRAILING ZEROS
  s390x/tcg: Implement VECTOR EXCLUSIVE OR
  s390x/tcg: Implement VECTOR GALOIS FIELD MULTIPLY SUM (AND ACCUMULATE)
  s390x/tcg: Implement VECTOR LOAD COMPLEMENT
  s390x/tcg: Implement VECTOR LOAD POSITIVE
  s390x/tcg: Implement VECTOR (MAXIMUM|MINIMUM) (LOGICAL)
  s390x/tcg: Implement VECTOR MULTIPLY AND ADD *
  s390x/tcg: Implement VECTOR MULTIPLY *
  s390x/tcg: Implement VECTOR NAND
  s390x/tcg: Implement VECTOR NOR
  s390x/tcg: Implement VECTOR NOT EXCLUSIVE OR
  s390x/tcg: Implement VECTOR OR
  s390x/tcg: Implement VECTOR OR WITH COMPLEMENT
  s390x/tcg: Implement VECTOR POPULATION COUNT
  s390x/tcg: Implement VECTOR ELEMENT ROTATE LEFT LOGICAL
  s390x/tcg: Implement VECTOR ELEMENT ROTATE AND INSERT UNDER MASK
  s390x/tcg: Implement VECTOR ELEMENT SHIFT
  s390x/tcg: Implement VECTOR SHIFT LEFT (BY BYTE)
  s390x/tcg: Implement VECTOR SHIFT LEFT DOUBLE BY BYTE
  s390x/tcg: Implement VECTOR SHIFT RIGHT ARITHMETIC
  s390x/tcg: Implement VECTOR SHIFT RIGHT LOGICAL *
  s390x/tcg: Implement VECTOR SUBTRACT
  s390x/tcg: Implement VECTOR SUBTRACT COMPUTE BORROW INDICATION
  s390x/tcg: Implement VECTOR SUBTRACT WITH BORROW INDICATION
  s390x/tcg: Implement VECTOR SUBTRACT WITH BORROW COMPUTE BORROW
    INDICATION
  s390x/tcg: Implement VECTOR SUM ACROSS DOUBLEWORD
  s390x/tcg: Implement VECTOR SUM ACROSS QUADWORD
  s390x/tcg: Implement VECTOR SUM ACROSS WORD
  s390x/tcg: Implement VECTOR TEST UNDER MASK

Jason J. Herne (1):
  s390-bios: Skip bootmap signature entries

Markus Armbruster (1):
  pc-bios/s390-ccw: Clean up harmless misuse of isdigit()

Thomas Huth (1):
  pc-bios/s390: Update firmware image with "Skip bootmap signature
    entries" fix

-- 
2.20.1



^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [Qemu-devel] [PULL v3 47/55] linux headers: update against Linux 5.2-rc1
@ 2019-05-22 13:50 Aleksandar Markovic
  0 siblings, 0 replies; 20+ messages in thread
From: Aleksandar Markovic @ 2019-05-22 13:50 UTC (permalink / raw)
  To: Alex Bennée
  Cc: Peter Maydell, Cornelia Huck, qemu-devel, Laurent Vivier,
	qemu-s390x, Aleksandar Markovic, Philippe Mathieu-Daudé

On May 22, 2019 3:42 PM, "Alex Bennée" <alex.bennee@linaro.org> wrote:
>
>
> Aleksandar Markovic <aleksandar.m.mail@gmail.com> writes:
>
> > On May 22, 2019 2:24 PM, "Cornelia Huck" <cohuck@redhat.com> wrote:
> >>
> >> On Wed, 22 May 2019 14:10:39 +0200
> >> Laurent Vivier <laurent@vivier.eu> wrote:
> >>
> >> > On 22/05/2019 14:07, Cornelia Huck wrote:
> >> > > On Wed, 22 May 2019 13:47:25 +0200
> >> > > Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> >> > >
> >> > >> On 5/21/19 5:28 PM, Cornelia Huck wrote:
> >> > >>> commit a188339ca5a396acc588e5851ed7e19f66b0ebd9
> >> > >>>
> >> > >>> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> >> > >>> ---
> >> > >> [...]
> >> > >>>   #define __NR_mq_notify 184
> >> > >>>   __SC_COMP(__NR_mq_notify, sys_mq_notify, compat_sys_mq_notify)
> >> > >>>   #define __NR_mq_getsetattr 185
> >> > >>> @@ -536,8 +567,10 @@ __SC_COMP(__NR_msgsnd, sys_msgsnd,
> > compat_sys_msgsnd)
> >> > >>>   __SYSCALL(__NR_semget, sys_semget)
> >> > >>>   #define __NR_semctl 191
> >> > >>>   __SC_COMP(__NR_semctl, sys_semctl, compat_sys_semctl)
> >> > >>> +#if defined(__ARCH_WANT_TIME32_SYSCALLS) || __BITS_PER_LONG !=
32
> >> > >
> >> > > Eww. It seems only aarch64 sets __ARCH_WANT_TIME32_SYSCALLS, and
the
> >> > > second condition probably catches others but not mipsel.
> >> > >
> >> > >>>   #define __NR_semtimedop 192
> >> > >>> -__SC_COMP(__NR_semtimedop, sys_semtimedop,
compat_sys_semtimedop)
> >> > >>> +__SC_COMP(__NR_semtimedop, sys_semtimedop,
sys_semtimedop_time32)
> >> > >>> +#endif
> >> > >>>   #define __NR_semop 193
> >> > >>>   __SYSCALL(__NR_semop, sys_semop)
> >> > >> [...]
> >> > >>
> >> > >>
https://app.shippable.com/github/qemu/qemu/runs/1703/summary/console
> >> > >>
> >> > >> It seems this commit introduce a regression on mips32:
> >> > >>
> >> > >>    CC      mipsel-linux-user/linux-user/syscall.o
> >> > >> ./linux-user/syscall.c: In function 'safe_semtimedop':
> >> > >> ./linux-user/syscall.c:697:25: error: '__NR_semtimedop' undeclared
> >> > >> (first use in this function)
> >> > >>       return safe_syscall(__NR_##name, arg1, arg2, arg3, arg4); \
> >> > >
> >> > > So, we unconditionally deal with this syscall, i.e. we assume it is
> >> > > always present? (I'm not sure of the logic in linux-user code.)
> >> > >
> >> >
> >> > linux-user assumes it is present if __NR_msgsnd is present.
> >>
> >> Hm. The kernel change seems to break that assumption. Does anyone with
> >> mips knowledge have an idea whether that was intentional (and the
> >> linux-user code needs to be changed), or whether that's an issue on the
> >> kernel side?
> >>
> >
> > Hi, Cornelia.
> >
> > Thanks for your involving into this issue!
> >
> > It could be that (not-originating-from-MIPS) kernel commit:
> >
> >
https://github.com/torvalds/linux/commit/1a787fc5ba18ac767e635c58d06a0b46876184e3
> >
> > made a mess with system call availability for MIPS (I will forward this
to
> > MIPS kernel maintainer Paul Burton). My impression is that this was not
> > intentional, and is a temporary instability of kernel interface.
>
> I think this stems from 2038 time bomb work. Eventually they want it to
> be possible to build non-legacy kernels that don't expose time32 to the
> outside world. As part of that new system calls are being introduced
> where needed. The IPC syscall which orignally multiplexed a bunch of
> these operations on some systems would eventually be potentially phased
> out.
>
> > However, I think that QEMU nevertheless should not make the assumption
that
> > if __NR_MSGSND, than semtimedop() is present. It could be true, but it
is
> > still just self-imposed belief in QEMU, kernel never guarantied such
things.
> >
> > The alternative way of invoking via IPCV6 (else part of “ifdef
> > __NR_MSGSND”) should work for MIPS in the present stage of headers and
> > kernel.
>
> Yeah I think #ifndef __NR_ipc would work for now. It shouldn't affect
> architectures that never had the IPC call.
>
> > As a side note, perhaps we shoul update kernel headers only off of
stable
> > kernel releases.
>
> I guess that's a part of the tension for supporting new kernel APIs
> quickly. At least 5.2-rc1 wasn't a random tree - you would expect the
> external facing ABI to be stable after the merge window closed. It would
> be nice to know what new features were being exposed though.
>

Yes, one would expect no intentional changes in ABI kernel headers would
happen after RC1. However, one must expect that there could certainly be
bugs in RC1 - and there is a larger risk of propagating these bugs to QEMU
with header updates from non-stable code.

Sincerely,
Aleksandar

> >
> > Regards,
> > Aleksandar
>
>
> --
> Alex Bennée

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2019-05-23 21:16 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-21 15:28 [Qemu-devel] [PULL v3 00/55] s390x update Cornelia Huck
2019-05-21 15:28 ` [Qemu-devel] [PULL v3 46/55] update-linux-headers: handle new header file Cornelia Huck
2019-05-21 15:28 ` [Qemu-devel] [PULL v3 47/55] linux headers: update against Linux 5.2-rc1 Cornelia Huck
2019-05-22 11:47   ` Philippe Mathieu-Daudé
2019-05-22 12:07     ` Cornelia Huck
2019-05-22 12:10       ` Laurent Vivier
2019-05-22 12:24         ` Cornelia Huck
2019-05-22 13:22           ` Aleksandar Markovic
2019-05-22 13:28             ` Aleksandar Markovic
2019-05-22 13:42             ` Alex Bennée
2019-05-22 13:50             ` Cornelia Huck
2019-05-23 21:15               ` Aleksandar Markovic
2019-05-23 11:56             ` Cornelia Huck
2019-05-23 12:30               ` Laurent Vivier
2019-05-23 12:58                 ` Philippe Mathieu-Daudé
2019-05-23 19:16                 ` Alex Bennée
2019-05-23 19:18                   ` Laurent Vivier
2019-05-22 13:33           ` Alex Bennée
2019-05-21 16:10 ` [Qemu-devel] [PULL v3 00/55] s390x update Peter Maydell
  -- strict thread matches above, loose matches on Subject: below --
2019-05-22 13:50 [Qemu-devel] [PULL v3 47/55] linux headers: update against Linux 5.2-rc1 Aleksandar Markovic

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).