From: Igor Mammedov <imammedo@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: yang.zhong@intel.com, peter.maydell@linaro.org, thuth@redhat.com,
qemu-devel@nongnu.org, shannon.zhaosl@gmail.com,
qemu-arm@nongnu.org, Wei Yang <richardw.yang@linux.intel.com>,
philmd@redhat.com
Subject: Re: [Qemu-devel] [PATCH v5 1/2] hw/acpi: Consolidate build_mcfg to pci.c
Date: Tue, 21 May 2019 16:15:04 +0200 [thread overview]
Message-ID: <20190521161504.75ca268c@redhat.com> (raw)
In-Reply-To: <20190520233730-mutt-send-email-mst@kernel.org>
On Mon, 20 May 2019 23:37:46 -0400
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Tue, May 21, 2019 at 11:32:48AM +0800, Wei Yang wrote:
> > Now we have two identical build_mcfg functions.
> >
> > Consolidate them in acpi/pci.c.
> >
> > Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> >
> > ---
> > v5:
> > * ACPI_PCI depends on both ACPI and PCI
> > * rebase on latest master, adjust arm Kconfig
> > v3:
> > * adjust changelog based on Igor's suggestion
> > ---
>
>
> same as 2/2 - do not use two --- separators pls.
I don't really get this requirement, it's common practice on
list(s) and used to work just fine.
The 1st separator is added by hand when editing commit message
to separate change log from main commit message so that 'git am'
would drop change log. While the second separator is added
automatically by git when patch is created.
next prev parent reply other threads:[~2019-05-21 14:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 3:32 [Qemu-devel] [PATCH v5 0/2] Extract build_mcfg Part 2 Wei Yang
2019-05-21 3:32 ` [Qemu-devel] [PATCH v5 1/2] hw/acpi: Consolidate build_mcfg to pci.c Wei Yang
2019-05-21 3:37 ` Michael S. Tsirkin
2019-05-21 14:15 ` Igor Mammedov [this message]
2019-05-21 3:32 ` [Qemu-devel] [PATCH v5 2/2] acpi: pci: use build_append_foo() API to construct MCFG Wei Yang
2019-05-21 3:37 ` Michael S. Tsirkin
2019-05-21 14:29 ` Igor Mammedov
2019-05-21 14:34 ` Michael S. Tsirkin
2019-05-22 8:20 ` Igor Mammedov
2019-05-21 3:44 ` Michael S. Tsirkin
2019-05-21 6:20 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521161504.75ca268c@redhat.com \
--to=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richardw.yang@linux.intel.com \
--cc=shannon.zhaosl@gmail.com \
--cc=thuth@redhat.com \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).