From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE693C072B5 for ; Wed, 22 May 2019 00:55:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85BF82070D for ; Wed, 22 May 2019 00:55:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85BF82070D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:33522 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTFXP-0007Ci-Pp for qemu-devel@archiver.kernel.org; Tue, 21 May 2019 20:55:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46540) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTFWR-0006et-Tr for qemu-devel@nongnu.org; Tue, 21 May 2019 20:54:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTFWQ-0000VW-UA for qemu-devel@nongnu.org; Tue, 21 May 2019 20:54:23 -0400 Received: from mga18.intel.com ([134.134.136.126]:64669) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hTFWQ-0000Td-L8 for qemu-devel@nongnu.org; Tue, 21 May 2019 20:54:22 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 May 2019 17:54:21 -0700 X-ExtLoop1: 1 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga004.fm.intel.com with ESMTP; 21 May 2019 17:54:20 -0700 Date: Wed, 22 May 2019 08:53:49 +0800 From: Wei Yang To: Markus Armbruster Message-ID: <20190522005349.GC14030@richard> References: <20190521081227.30799-1-richardw.yang@linux.intel.com> <87lfyzrfms.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lfyzrfms.fsf@dusky.pond.sub.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.126 Subject: Re: [Qemu-devel] [PATCH] Makefile: simplify qapi-py definition with wildcard X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Wei Yang Cc: berrange@redhat.com, philmd@redhat.com, qemu-devel@nongnu.org, Wei Yang , alex.bennee@linaro.org, kraxel@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, May 21, 2019 at 05:28:27PM +0200, Markus Armbruster wrote: >Eric Blake writes: > >> On 5/21/19 3:12 AM, Wei Yang wrote: >>> All the python script in scripts/qapi is used to generate qapi code. Use >>> wildcard to simplify it. >>> >>> Signed-off-by: Wei Yang >>> --- >>> Makefile | 8 +------- >>> 1 file changed, 1 insertion(+), 7 deletions(-) >> >> I'm not a fan of $(wildcard). It makes your tarball creation >> non-deterministic - if there is a leftover file from development that is >> no longer part of the build, wildcard will still pick it up. Explicit > >Actually, in this case can "only" adds spurious prerequisites. Hmm... which spurious prerequisites will be added? I may miss something here. > >> lists are better. I'm inclined to NACK this, but Markus has final say >> since he maintains the qapi generator. > >I consider use of $(wildcard) for the purpose of collecting sources a >lazy mistake. -- Wei Yang Help you, Help me