From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7240FC18E7D for ; Wed, 22 May 2019 10:10:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4AC81217F9 for ; Wed, 22 May 2019 10:10:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4AC81217F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:39622 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTOCt-0004Sa-Eu for qemu-devel@archiver.kernel.org; Wed, 22 May 2019 06:10:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTO78-0008E8-RN for qemu-devel@nongnu.org; Wed, 22 May 2019 06:04:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTNwT-0001Wm-GS for qemu-devel@nongnu.org; Wed, 22 May 2019 05:53:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59084) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hTNwS-0001Va-B1; Wed, 22 May 2019 05:53:48 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9A9406378; Wed, 22 May 2019 09:53:47 +0000 (UTC) Received: from localhost.localdomain (ovpn-117-92.ams2.redhat.com [10.36.117.92]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 04644604C8; Wed, 22 May 2019 09:53:42 +0000 (UTC) Date: Wed, 22 May 2019 11:53:42 +0200 From: Kevin Wolf To: John Snow Message-ID: <20190522095342.GB6087@localhost.localdomain> References: <20190513150638.14622-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190513150638.14622-1-jsnow@redhat.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 22 May 2019 09:53:47 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v2] blockdev: fix missed target unref for drive-backup X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Markus Armbruster , aihua liang , qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 13.05.2019 um 17:06 hat John Snow geschrieben: > If the bitmap can't be used for whatever reason, we skip putting down > the reference. Fix that. > > In practice, this means that if you attempt to gracefully exit QEMU > after a backup command being rejected, bdrv_close_all will fail and > tell you some unpleasant things via assert(). > > Reported-by: aihua liang > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1703916 > Signed-off-by: John Snow > Reviewed-by: Kevin Wolf Thanks, applied to the block branch. Kevin