From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: lvivier@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v8 02/25] build: Link user-only with crypto random number objects
Date: Wed, 22 May 2019 11:56:14 +0100 [thread overview]
Message-ID: <20190522105614.GD32359@redhat.com> (raw)
In-Reply-To: <a928e588-63dc-ed4c-fcdc-9001941559fd@linaro.org>
On Wed, May 22, 2019 at 06:52:45AM -0400, Richard Henderson wrote:
> On 5/21/19 11:04 AM, Daniel P. Berrangé wrote:
> > On Thu, May 16, 2019 at 07:39:01PM -0700, Richard Henderson wrote:
> >> For user-only, we require only the random number bits of the
> >> crypto subsystem. Rename crypto-aes-obj-y to crypto-user-obj-y,
> >> and add the random number objects, plus init.o to handle any
> >> extra stuff the crypto library requires.
> >
> > If you pull in my authz patch first:
> >
> > https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg04863.html
> >
> > then we can just kill crypto-aes-obj-y entirely, and make
> > linux-user reference crypto-obj-y as normal. My patch avoids
> > pulling in PAM, and your previous patch takes care of the
> > static linking problem.
>
> You would think so, wouldn't you. And yet, not.
>
> CC authz/base.o
> /home/rth/qemu/qemu/authz/base.c:23:10: fatal error: trace.h: No such file or
> directory
> #include "trace.h"
> ^~~~~~~~~
> compilation terminated.
>
> We're missing some dependency somewhere, and I have no idea what's missing.
>
> This for
>
> ../qemu/configure --static --disable-system --disable-tools
>
> I have a working configuration here in v8. Can we please leave the bikeshed
> unpainted for the moment and you can adjust the makefiles as you see fit afterward?
Yep, ok. I'll be away on holiday for a while so don't have time to look
into it now. So lets get this merged as is & I'll investigate further
when I come back.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2019-05-22 10:57 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 2:38 [Qemu-devel] [PATCH v8 00/25] Add qemu_getrandom and ARMv8.5-RNG etc Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 01/25] configure: Link test before auto-enabling crypto libraries Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 02/25] build: Link user-only with crypto random number objects Richard Henderson
2019-05-21 15:04 ` Daniel P. Berrangé
2019-05-22 10:52 ` Richard Henderson
2019-05-22 10:56 ` Daniel P. Berrangé [this message]
2019-05-22 10:58 ` Richard Henderson
2019-05-22 11:36 ` Laurent Vivier
2019-05-22 10:56 ` Daniel P. Berrangé
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 03/25] crypto: Reverse code blocks in random-platform.c Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 04/25] crypto: Do not fail for EINTR during qcrypto_random_bytes Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 05/25] crypto: Use O_CLOEXEC in qcrypto_random_init Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 06/25] crypto: Use getrandom for qcrypto_random_bytes Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 07/25] crypto: Change the qcrypto_random_bytes buffer type to void* Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 08/25] ui/vnc: Split out authentication_failed Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 09/25] ui/vnc: Use gcrypto_random_bytes for start_auth_vnc Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 10/25] util: Add qemu_guest_getrandom and associated routines Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 11/25] cpus: Initialize pseudo-random seeds for all guest cpus Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 12/25] linux-user: " Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 13/25] linux-user: Call qcrypto_init if not using -seed Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 14/25] linux-user: Use qemu_guest_getrandom_nofail for AT_RANDOM Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 15/25] linux-user/aarch64: Use qemu_guest_getrandom for PAUTH keys Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 16/25] linux-user: Remove srand call Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 17/25] aspeed/scu: Use qemu_guest_getrandom_nofail Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 18/25] hw/misc/nrf51_rng: " Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 19/25] hw/misc/bcm2835_rng: " Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 20/25] hw/misc/exynos4210_rng: Use qemu_guest_getrandom Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 21/25] target/arm: Put all PAC keys into a structure Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 22/25] target/arm: Implement ARMv8.5-RNG Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 23/25] target/ppc: Use gen_io_start/end around DARN Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 24/25] target/ppc: Use qemu_guest_getrandom for DARN Richard Henderson
2019-05-17 2:39 ` [Qemu-devel] [PATCH v8 25/25] target/i386: Implement CPUID_EXT_RDRAND Richard Henderson
2019-05-22 10:58 ` [Qemu-devel] [PATCH v8 00/25] Add qemu_getrandom and ARMv8.5-RNG etc Daniel P. Berrangé
2019-05-22 11:37 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522105614.GD32359@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).