From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B389CC282CE for ; Wed, 22 May 2019 12:25:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 879D72173C for ; Wed, 22 May 2019 12:25:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 879D72173C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:42562 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTQJC-0002oP-NX for qemu-devel@archiver.kernel.org; Wed, 22 May 2019 08:25:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTQIS-0002V6-JQ for qemu-devel@nongnu.org; Wed, 22 May 2019 08:24:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTQIP-0001xq-8v for qemu-devel@nongnu.org; Wed, 22 May 2019 08:24:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38380) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hTQIO-0001uO-26; Wed, 22 May 2019 08:24:36 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 447813083392; Wed, 22 May 2019 12:24:29 +0000 (UTC) Received: from gondolin (dhcp-192-213.str.redhat.com [10.33.192.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id 741E1619C5; Wed, 22 May 2019 12:24:23 +0000 (UTC) Date: Wed, 22 May 2019 14:24:21 +0200 From: Cornelia Huck To: Laurent Vivier Message-ID: <20190522142421.746f7495.cohuck@redhat.com> In-Reply-To: <6b101b85-4985-4736-acad-59389b00de55@vivier.eu> References: <20190521152810.21353-1-cohuck@redhat.com> <20190521152810.21353-3-cohuck@redhat.com> <6e216877-60be-ddcd-3f15-604e870ca8ba@redhat.com> <20190522140729.25970e17.cohuck@redhat.com> <6b101b85-4985-4736-acad-59389b00de55@vivier.eu> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Wed, 22 May 2019 12:24:34 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PULL v3 47/55] linux headers: update against Linux 5.2-rc1 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , qemu-devel@nongnu.org, qemu-s390x@nongnu.org, Aleksandar Markovic , Alex =?UTF-8?B?QmVubsOpZQ==?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 22 May 2019 14:10:39 +0200 Laurent Vivier wrote: > On 22/05/2019 14:07, Cornelia Huck wrote: > > On Wed, 22 May 2019 13:47:25 +0200 > > Philippe Mathieu-Daud=C3=A9 wrote: > > =20 > >> On 5/21/19 5:28 PM, Cornelia Huck wrote: =20 > >>> commit a188339ca5a396acc588e5851ed7e19f66b0ebd9 > >>> > >>> Signed-off-by: Cornelia Huck > >>> --- =20 > >> [...] =20 > >>> #define __NR_mq_notify 184 > >>> __SC_COMP(__NR_mq_notify, sys_mq_notify, compat_sys_mq_notify) > >>> #define __NR_mq_getsetattr 185 > >>> @@ -536,8 +567,10 @@ __SC_COMP(__NR_msgsnd, sys_msgsnd, compat_sys_ms= gsnd) > >>> __SYSCALL(__NR_semget, sys_semget) > >>> #define __NR_semctl 191 > >>> __SC_COMP(__NR_semctl, sys_semctl, compat_sys_semctl) > >>> +#if defined(__ARCH_WANT_TIME32_SYSCALLS) || __BITS_PER_LONG !=3D 32 = =20 > >=20 > > Eww. It seems only aarch64 sets __ARCH_WANT_TIME32_SYSCALLS, and the > > second condition probably catches others but not mipsel. > > =20 > >>> #define __NR_semtimedop 192 > >>> -__SC_COMP(__NR_semtimedop, sys_semtimedop, compat_sys_semtimedop) > >>> +__SC_COMP(__NR_semtimedop, sys_semtimedop, sys_semtimedop_time32) > >>> +#endif > >>> #define __NR_semop 193 > >>> __SYSCALL(__NR_semop, sys_semop) =20 > >> [...] > >> > >> https://app.shippable.com/github/qemu/qemu/runs/1703/summary/console > >> > >> It seems this commit introduce a regression on mips32: > >> > >> CC mipsel-linux-user/linux-user/syscall.o > >> ./linux-user/syscall.c: In function 'safe_semtimedop': > >> ./linux-user/syscall.c:697:25: error: '__NR_semtimedop' undeclared > >> (first use in this function) > >> return safe_syscall(__NR_##name, arg1, arg2, arg3, arg4); \ =20 > >=20 > > So, we unconditionally deal with this syscall, i.e. we assume it is > > always present? (I'm not sure of the logic in linux-user code.) > > =20 >=20 > linux-user assumes it is present if __NR_msgsnd is present. Hm. The kernel change seems to break that assumption. Does anyone with mips knowledge have an idea whether that was intentional (and the linux-user code needs to be changed), or whether that's an issue on the kernel side?