From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v3 4/8] block/commit: Drop bdrv_child_try_set_perm()
Date: Wed, 22 May 2019 19:03:48 +0200 [thread overview]
Message-ID: <20190522170352.12020-5-mreitz@redhat.com> (raw)
In-Reply-To: <20190522170352.12020-1-mreitz@redhat.com>
commit_top_bs never requests or unshares any permissions. There is no
reason to make this so explicit here.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
---
block/commit.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/block/commit.c b/block/commit.c
index 14e5bb394c..44b3083b84 100644
--- a/block/commit.c
+++ b/block/commit.c
@@ -110,8 +110,6 @@ static void commit_abort(Job *job)
* XXX Can (or should) we somehow keep 'consistent read' blocked even
* after the failed/cancelled commit job is gone? If we already wrote
* something to base, the intermediate images aren't valid any more. */
- bdrv_child_try_set_perm(s->commit_top_bs->backing, 0, BLK_PERM_ALL,
- &error_abort);
bdrv_replace_node(s->commit_top_bs, backing_bs(s->commit_top_bs),
&error_abort);
--
2.21.0
next prev parent reply other threads:[~2019-05-22 17:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 17:03 [Qemu-devel] [PATCH v3 0/8] block: Ignore loosening perm restrictions failures Max Reitz
2019-05-22 17:03 ` [Qemu-devel] [PATCH v3 1/8] file-posix: Update open_flags in raw_set_perm() Max Reitz
2019-05-22 17:03 ` [Qemu-devel] [PATCH v3 2/8] block: Add bdrv_child_refresh_perms() Max Reitz
2019-05-22 17:03 ` [Qemu-devel] [PATCH v3 3/8] block/mirror: Fix child permissions Max Reitz
2019-05-22 17:03 ` Max Reitz [this message]
2019-05-22 17:03 ` [Qemu-devel] [PATCH v3 5/8] block: Fix order in bdrv_replace_child() Max Reitz
2019-05-22 17:03 ` [Qemu-devel] [PATCH v3 6/8] block: Add *tighten_restrictions to *check*_perm() Max Reitz
2019-05-22 17:03 ` [Qemu-devel] [PATCH v3 7/8] block: Ignore loosening perm restrictions failures Max Reitz
2019-05-22 17:03 ` [Qemu-devel] [PATCH v3 8/8] iotests: Test failure to loosen restrictions Max Reitz
2019-05-22 18:24 ` [Qemu-devel] [PATCH v3 0/8] block: Ignore loosening perm restrictions failures Eric Blake
2019-05-22 18:37 ` Max Reitz
2019-05-22 19:31 ` Eric Blake
2019-06-13 19:44 ` Max Reitz
2019-06-14 14:02 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522170352.12020-5-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).