From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: [Qemu-devel] [PULL 07/25] crypto: Change the qcrypto_random_bytes buffer type to void*
Date: Wed, 22 May 2019 14:42:08 -0400 [thread overview]
Message-ID: <20190522184226.17871-8-richard.henderson@linaro.org> (raw)
In-Reply-To: <20190522184226.17871-1-richard.henderson@linaro.org>
Using uint8_t* merely requires useless casts for use with
other types to be filled with randomness.
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
include/crypto/random.h | 2 +-
crypto/random-gcrypt.c | 2 +-
crypto/random-gnutls.c | 2 +-
crypto/random-platform.c | 4 ++--
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/crypto/random.h b/include/crypto/random.h
index 8764ca0562..fde592904e 100644
--- a/include/crypto/random.h
+++ b/include/crypto/random.h
@@ -34,7 +34,7 @@
*
* Returns 0 on success, -1 on error
*/
-int qcrypto_random_bytes(uint8_t *buf,
+int qcrypto_random_bytes(void *buf,
size_t buflen,
Error **errp);
diff --git a/crypto/random-gcrypt.c b/crypto/random-gcrypt.c
index 9f1c9ee60e..7aea4ac81f 100644
--- a/crypto/random-gcrypt.c
+++ b/crypto/random-gcrypt.c
@@ -24,7 +24,7 @@
#include <gcrypt.h>
-int qcrypto_random_bytes(uint8_t *buf,
+int qcrypto_random_bytes(void *buf,
size_t buflen,
Error **errp G_GNUC_UNUSED)
{
diff --git a/crypto/random-gnutls.c b/crypto/random-gnutls.c
index 445fd6a30b..ed6c9ca12f 100644
--- a/crypto/random-gnutls.c
+++ b/crypto/random-gnutls.c
@@ -26,7 +26,7 @@
#include <gnutls/gnutls.h>
#include <gnutls/crypto.h>
-int qcrypto_random_bytes(uint8_t *buf,
+int qcrypto_random_bytes(void *buf,
size_t buflen,
Error **errp)
{
diff --git a/crypto/random-platform.c b/crypto/random-platform.c
index cb3ca1bc09..66624106fe 100644
--- a/crypto/random-platform.c
+++ b/crypto/random-platform.c
@@ -64,8 +64,8 @@ int qcrypto_random_init(Error **errp)
return 0;
}
-int qcrypto_random_bytes(uint8_t *buf G_GNUC_UNUSED,
- size_t buflen G_GNUC_UNUSED,
+int qcrypto_random_bytes(void *buf,
+ size_t buflen,
Error **errp)
{
#ifdef _WIN32
--
2.17.1
next prev parent reply other threads:[~2019-05-22 19:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 18:42 [Qemu-devel] [PULL 00/25] Add qemu_getrandom and ARMv8.5-RNG etc Richard Henderson
2019-05-22 18:42 ` [Qemu-devel] [PULL 01/25] configure: Link test before auto-enabling crypto libraries Richard Henderson
2019-05-22 18:42 ` [Qemu-devel] [PULL 02/25] build: Link user-only with crypto random number objects Richard Henderson
2019-05-22 18:42 ` [Qemu-devel] [PULL 03/25] crypto: Reverse code blocks in random-platform.c Richard Henderson
2019-05-22 18:42 ` [Qemu-devel] [PULL 04/25] crypto: Do not fail for EINTR during qcrypto_random_bytes Richard Henderson
2019-05-22 18:42 ` [Qemu-devel] [PULL 05/25] crypto: Use O_CLOEXEC in qcrypto_random_init Richard Henderson
2019-05-22 18:42 ` [Qemu-devel] [PULL 06/25] crypto: Use getrandom for qcrypto_random_bytes Richard Henderson
2019-05-22 18:42 ` Richard Henderson [this message]
2019-05-22 18:42 ` [Qemu-devel] [PULL 08/25] ui/vnc: Split out authentication_failed Richard Henderson
2019-05-22 18:42 ` [Qemu-devel] [PULL 09/25] ui/vnc: Use gcrypto_random_bytes for start_auth_vnc Richard Henderson
2019-05-22 18:42 ` [Qemu-devel] [PULL 10/25] util: Add qemu_guest_getrandom and associated routines Richard Henderson
2019-05-30 11:29 ` Peter Maydell
2019-05-30 13:41 ` Richard Henderson
2019-05-30 13:45 ` Peter Maydell
2019-05-22 18:42 ` [Qemu-devel] [PULL 11/25] cpus: Initialize pseudo-random seeds for all guest cpus Richard Henderson
2019-05-22 18:42 ` [Qemu-devel] [PULL 12/25] linux-user: " Richard Henderson
2019-05-22 18:42 ` [Qemu-devel] [PULL 13/25] linux-user: Call qcrypto_init if not using -seed Richard Henderson
2019-05-22 18:42 ` [Qemu-devel] [PULL 14/25] linux-user: Use qemu_guest_getrandom_nofail for AT_RANDOM Richard Henderson
2019-05-22 18:42 ` [Qemu-devel] [PULL 15/25] linux-user/aarch64: Use qemu_guest_getrandom for PAUTH keys Richard Henderson
2019-05-22 18:42 ` [Qemu-devel] [PULL 16/25] linux-user: Remove srand call Richard Henderson
2019-05-22 18:42 ` [Qemu-devel] [PULL 17/25] aspeed/scu: Use qemu_guest_getrandom_nofail Richard Henderson
2019-05-22 18:42 ` [Qemu-devel] [PULL 18/25] hw/misc/nrf51_rng: " Richard Henderson
2019-05-22 18:42 ` [Qemu-devel] [PULL 19/25] hw/misc/bcm2835_rng: " Richard Henderson
2019-05-22 18:42 ` [Qemu-devel] [PULL 20/25] hw/misc/exynos4210_rng: Use qemu_guest_getrandom Richard Henderson
2019-05-22 18:42 ` [Qemu-devel] [PULL 21/25] target/arm: Put all PAC keys into a structure Richard Henderson
2019-05-22 18:42 ` [Qemu-devel] [PULL 22/25] target/arm: Implement ARMv8.5-RNG Richard Henderson
2019-05-22 18:42 ` [Qemu-devel] [PULL 23/25] target/ppc: Use gen_io_start/end around DARN Richard Henderson
2019-05-22 18:42 ` [Qemu-devel] [PULL 24/25] target/ppc: Use qemu_guest_getrandom for DARN Richard Henderson
2019-05-22 18:42 ` [Qemu-devel] [PULL 25/25] target/i386: Implement CPUID_EXT_RDRAND Richard Henderson
2019-05-23 13:14 ` [Qemu-devel] [PULL 00/25] Add qemu_getrandom and ARMv8.5-RNG etc Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522184226.17871-8-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).