From: Pankaj Gupta <pagupta@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, aarcange@redhat.com, cohuck@redhat.com,
xiaoguangrong.eric@gmail.com, mst@redhat.com, pagupta@redhat.com,
riel@surriel.com, david@redhat.com, armbru@redhat.com,
ehabkost@redhat.com, lcapitulino@redhat.com, stefanha@redhat.com,
pbonzini@redhat.com, imammedo@redhat.com,
dan.j.williams@intel.com, nilal@redhat.com, dgilbert@redhat.com,
rth@twiddle.net
Subject: [Qemu-devel] [PATCH 2/7] virtio-pci: Allow to specify additional interfaces for the base type
Date: Thu, 23 May 2019 15:54:44 +0530 [thread overview]
Message-ID: <20190523102449.2642-3-pagupta@redhat.com> (raw)
In-Reply-To: <20190523102449.2642-1-pagupta@redhat.com>
From: David Hildenbrand <david@redhat.com>
Let's allow to specify additional interfaces for the base type (e.g.
later TYPE_MEMORY_DEVICE), something that was possible before the
rework of virtio PCI device instantiation.
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/virtio/virtio-pci.c | 1 +
hw/virtio/virtio-pci.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index cb44e19b67..0ac451ed0f 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -1939,6 +1939,7 @@ void virtio_pci_types_register(const VirtioPCIDeviceTypeInfo *t)
.class_init = virtio_pci_base_class_init,
.class_data = (void *)t,
.abstract = true,
+ .interfaces = t->interfaces,
};
TypeInfo generic_type_info = {
.name = t->generic_name,
diff --git a/hw/virtio/virtio-pci.h b/hw/virtio/virtio-pci.h
index 18581854ca..292275acb1 100644
--- a/hw/virtio/virtio-pci.h
+++ b/hw/virtio/virtio-pci.h
@@ -233,6 +233,7 @@ typedef struct VirtioPCIDeviceTypeInfo {
size_t class_size;
void (*instance_init)(Object *obj);
void (*class_init)(ObjectClass *klass, void *data);
+ InterfaceInfo *interfaces;
} VirtioPCIDeviceTypeInfo;
/* Register virtio-pci type(s). @t must be static. */
--
2.14.5
next prev parent reply other threads:[~2019-05-23 10:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 10:24 [Qemu-devel] [PATCH 0/7] Qemu virtio pmem device Pankaj Gupta
2019-05-23 10:24 ` [Qemu-devel] [PATCH 1/7] virtio-pmem: add virtio device Pankaj Gupta
2019-05-23 13:21 ` Eric Blake
2019-05-24 6:01 ` Pankaj Gupta
2019-06-04 13:15 ` Cornelia Huck
2019-06-10 5:09 ` Pankaj Gupta
2019-05-23 10:24 ` Pankaj Gupta [this message]
2019-05-23 10:24 ` [Qemu-devel] [PATCH 3/7] virtio-pmem: sync linux headers Pankaj Gupta
2019-05-23 10:24 ` [Qemu-devel] [PATCH 4/7] virtio-pci: Proxy for virtio-pmem Pankaj Gupta
2019-05-23 10:24 ` [Qemu-devel] [PATCH 5/7] hmp: Handle virtio-pmem when printing memory device infos Pankaj Gupta
2019-05-23 10:24 ` [Qemu-devel] [PATCH 6/7] numa: Handle virtio-pmem in NUMA stats Pankaj Gupta
2019-05-23 10:24 ` [Qemu-devel] [PATCH 7/7] pc: Support for virtio-pmem-pci Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523102449.2642-3-pagupta@redhat.com \
--to=pagupta@redhat.com \
--cc=aarcange@redhat.com \
--cc=armbru@redhat.com \
--cc=cohuck@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mst@redhat.com \
--cc=nilal@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riel@surriel.com \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).