From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: fam@euphon.net, kwolf@redhat.com, vsementsov@virtuozzo.com,
mreitz@redhat.com, den@openvz.org, jsnow@redhat.com
Subject: [Qemu-devel] [PATCH 0/3] qcow2-bitmaps: rewrite reopening logic
Date: Thu, 23 May 2019 18:47:30 +0300 [thread overview]
Message-ID: <20190523154733.54944-1-vsementsov@virtuozzo.com> (raw)
Hi all!
Bitmaps reopening is buggy, we may easily produce broken incremental
backup if we do temporary snaphost. Let's fix it! The main patch is 03
and it has full description of the problem and solution.
Vladimir Sementsov-Ogievskiy (3):
iotests: add test 255 to check bitmap life after snapshot + commit
block/qcow2-bitmap: get rid of bdrv_has_changed_persistent_bitmaps
block/qcow2-bitmap: rewrite bitmap reopening logic
block/qcow2.h | 5 +-
include/block/block_int.h | 2 +-
include/block/dirty-bitmap.h | 1 -
block.c | 29 ++---
block/dirty-bitmap.c | 12 --
block/qcow2-bitmap.c | 220 ++++++++++++++++++++++++-----------
block/qcow2.c | 2 +-
python/qemu/__init__.py | 4 +-
tests/qemu-iotests/255 | 83 +++++++++++++
tests/qemu-iotests/255.out | 52 +++++++++
tests/qemu-iotests/group | 1 +
11 files changed, 308 insertions(+), 103 deletions(-)
create mode 100755 tests/qemu-iotests/255
create mode 100644 tests/qemu-iotests/255.out
--
2.18.0
next reply other threads:[~2019-05-23 15:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 15:47 Vladimir Sementsov-Ogievskiy [this message]
2019-05-23 15:47 ` [Qemu-devel] [PATCH 1/3] iotests: add test 255 to check bitmap life after snapshot + commit Vladimir Sementsov-Ogievskiy
2019-05-24 23:15 ` John Snow
2019-05-25 9:16 ` Vladimir Sementsov-Ogievskiy
2019-05-23 15:47 ` [Qemu-devel] [PATCH 2/3] block/qcow2-bitmap: get rid of bdrv_has_changed_persistent_bitmaps Vladimir Sementsov-Ogievskiy
2019-05-24 23:37 ` John Snow
2019-05-23 15:47 ` [Qemu-devel] [PATCH 3/3] block/qcow2-bitmap: rewrite bitmap reopening logic Vladimir Sementsov-Ogievskiy
2019-05-28 23:24 ` John Snow
2019-05-29 9:10 ` Vladimir Sementsov-Ogievskiy
2019-05-29 18:08 ` John Snow
2019-05-30 8:23 ` Vladimir Sementsov-Ogievskiy
2019-05-30 11:54 ` Vladimir Sementsov-Ogievskiy
2019-05-30 14:20 ` John Snow
2019-05-30 14:39 ` Vladimir Sementsov-Ogievskiy
2019-05-29 15:33 ` Max Reitz
2019-05-29 15:58 ` Vladimir Sementsov-Ogievskiy
2019-05-29 18:18 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523154733.54944-1-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=den@openvz.org \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).