From: Stefan Hajnoczi <stefanha@redhat.com>
To: <qemu-devel@nongnu.org>
Cc: Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [RFC v3 0/3] scsi: restart dma after vm change state handlers
Date: Fri, 24 May 2019 19:36:35 +0100 [thread overview]
Message-ID: <20190524183638.20745-1-stefanha@redhat.com> (raw)
v3:
* Fix s/k->vmstate_change/vdc->vmstate_change/
* Still RFC, waiting for customer to confirm this fixes the issue
v2:
* Do it properly with a clean API instead of deferring to a BH!
Thanks for encouraging me to do this, Kevin.
These patches solve a deadlock when the 'cont' command is used and there are
failed requests on a virtio-scsi device with iothreads. The deadlock itself is
actually not the thing we need to fix because we should never reach that case
anyway. Instead we need to make sure DMA restart is only performed after the
virtio-scsi iothread is re-initialized.
Stefan Hajnoczi (3):
virtio: add vdc->vmchange_state() callback
scsi: add scsi_bus_dma_restart()
virtio-scsi: fix iothread deadlock on 'cont'
include/hw/scsi/scsi.h | 5 +++++
include/hw/virtio/virtio.h | 7 +++++++
hw/scsi/scsi-bus.c | 37 ++++++++++++++++++++++++++++++-------
hw/scsi/virtio-scsi.c | 17 +++++++++++++++++
hw/virtio/virtio.c | 9 +++++++++
5 files changed, 68 insertions(+), 7 deletions(-)
--
2.21.0
next reply other threads:[~2019-05-24 18:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 18:36 Stefan Hajnoczi [this message]
2019-05-24 18:36 ` [Qemu-devel] [RFC v3 1/3] virtio: add vdc->vmchange_state() callback Stefan Hajnoczi
2019-05-24 18:36 ` [Qemu-devel] [RFC v3 2/3] scsi: add scsi_bus_dma_restart() Stefan Hajnoczi
2019-05-24 18:36 ` [Qemu-devel] [RFC v3 3/3] virtio-scsi: fix iothread deadlock on 'cont' Stefan Hajnoczi
2019-05-24 18:47 ` [Qemu-devel] [RFC v3 0/3] scsi: restart dma after vm change state handlers Paolo Bonzini
2019-05-24 19:08 ` Michael S. Tsirkin
2019-05-29 22:10 ` Kevin Wolf
2019-05-30 8:27 ` Paolo Bonzini
2019-05-30 8:52 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524183638.20745-1-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).