From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, richard.henderson@linaro.org, philmd@redhat.com
Subject: [Qemu-devel] [PATCH 2/4] Makefile: Drop bogus cleaning of $(ALL_SUBDIRS)/qemu-options.def
Date: Tue, 28 May 2019 10:23:06 +0200 [thread overview]
Message-ID: <20190528082308.22032-3-armbru@redhat.com> (raw)
In-Reply-To: <20190528082308.22032-1-armbru@redhat.com>
When commit df2943ba3c7 moved "rm -f qemu-options.def" from distclean
to clean, it also added "rm -f $$d/qemu-options.def" to the for d in
$(ALL_SUBDIRS) loop. That file doesn't exist. Remove the mistaken
rm.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/Makefile b/Makefile
index 940594cc7c..80c9c6416f 100644
--- a/Makefile
+++ b/Makefile
@@ -658,7 +658,6 @@ clean:
rm -rf qga/qapi-generated
for d in $(ALL_SUBDIRS); do \
if test -d $$d; then $(MAKE) -C $$d $@ || exit 1; fi; \
- rm -f $$d/qemu-options.def; \
done
rm -f config-all-devices.mak
--
2.17.2
next prev parent reply other threads:[~2019-05-28 8:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 8:23 [Qemu-devel] [PATCH 0/4] Makefile: Generalize recursion machinery Markus Armbruster
2019-05-28 8:23 ` [Qemu-devel] [PATCH 1/4] Makefile: Remove code to smooth transition to config.status Markus Armbruster
2019-05-28 8:23 ` Markus Armbruster [this message]
2019-05-28 8:23 ` [Qemu-devel] [PATCH 3/4] Makefile: Rename targets for make recursion Markus Armbruster
2019-07-03 11:24 ` Markus Armbruster
2019-07-03 11:49 ` Philippe Mathieu-Daudé
2019-05-28 8:23 ` [Qemu-devel] [PATCH 4/4] Makefile: Reuse all's recursion machinery for clean and install Markus Armbruster
2019-05-28 15:55 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528082308.22032-3-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).