From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ACE8C04AB6 for ; Tue, 28 May 2019 17:02:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74FFD2166E for ; Tue, 28 May 2019 17:02:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74FFD2166E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:39752 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVfUh-00007q-6m for qemu-devel@archiver.kernel.org; Tue, 28 May 2019 13:02:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVfT0-0007RS-6r for qemu-devel@nongnu.org; Tue, 28 May 2019 13:00:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVfSw-0008Is-Bb for qemu-devel@nongnu.org; Tue, 28 May 2019 13:00:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59204) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hVfSn-0007ve-Sn; Tue, 28 May 2019 13:00:40 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 50EB76147C; Tue, 28 May 2019 17:00:26 +0000 (UTC) Received: from gondolin (dhcp-192-222.str.redhat.com [10.33.192.222]) by smtp.corp.redhat.com (Postfix) with ESMTP id B873F8082; Tue, 28 May 2019 17:00:03 +0000 (UTC) Date: Tue, 28 May 2019 19:00:01 +0200 From: Cornelia Huck To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Message-ID: <20190528190001.17d7cdf0.cohuck@redhat.com> In-Reply-To: <20190528164020.32250-5-philmd@redhat.com> References: <20190528164020.32250-1-philmd@redhat.com> <20190528164020.32250-5-philmd@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 28 May 2019 17:00:26 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v2 04/10] hw/s390x/event-facility: Use the QOM BUS() macro to access BusState.qbus X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Dmitry Fleytman , Alex Williamson , Aleksandar Markovic , "Michael S. Tsirkin" , qemu-trivial@nongnu.org, David Hildenbrand , qemu-devel@nongnu.org, Markus Armbruster , Halil Pasic , Aleksandar Rikalo , Michael Walle , Gerd Hoffmann , qemu-s390x@nongnu.org, Paolo Bonzini , Christian Borntraeger , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 28 May 2019 18:40:14 +0200 Philippe Mathieu-Daud=C3=A9 wrote: > Rather than looking inside the definition of a BusState with "s->bus.qbus= ", > use the QOM prefered style: "BUS(&s->bus)". >=20 > This patch was generated using the following Coccinelle script: >=20 > // Use BUS() macros to access BusState.qbus > @use_bus_macro_to_access_qbus@ > expression obj; > identifier bus; > @@ > -&obj->bus.qbus > +BUS(&obj->bus) >=20 > Suggested-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > hw/s390x/event-facility.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Cornelia Huck (I assume this will go through the trivial tree?)