From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PULL 20/21] qcow2-bitmap: initialize bitmap directory alignment
Date: Tue, 28 May 2019 21:28:46 +0200 [thread overview]
Message-ID: <20190528192847.2730-21-mreitz@redhat.com> (raw)
In-Reply-To: <20190528192847.2730-1-mreitz@redhat.com>
From: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Valgrind detects multiple issues in QEMU iotests when the memory is
used without being initialized. Valgrind may dump lots of unnecessary
reports what makes the memory issue analysis harder. Particularly,
that is true for the aligned bitmap directory and can be seen while
running the iotest #169. Padding the aligned space with zeros eases
the pain.
Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Message-id: 1558961521-131620-1-git-send-email-andrey.shinkevich@virtuozzo.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
block/qcow2-bitmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c
index 640da68ce1..b2487101ed 100644
--- a/block/qcow2-bitmap.c
+++ b/block/qcow2-bitmap.c
@@ -753,7 +753,7 @@ static int bitmap_list_store(BlockDriverState *bs, Qcow2BitmapList *bm_list,
dir_offset = *offset;
}
- dir = g_try_malloc(dir_size);
+ dir = g_try_malloc0(dir_size);
if (dir == NULL) {
return -ENOMEM;
}
--
2.21.0
next prev parent reply other threads:[~2019-05-28 19:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 19:28 [Qemu-devel] [PULL 00/21] Block patches Max Reitz
2019-05-28 19:28 ` [Qemu-devel] [PULL 01/21] qcow2.h: add missing include Max Reitz
2019-05-28 19:28 ` [Qemu-devel] [PULL 02/21] qcow2: add separate file for threaded data processing functions Max Reitz
2019-05-28 19:28 ` [Qemu-devel] [PULL 03/21] qcow2-threads: use thread_pool_submit_co Max Reitz
2019-05-28 19:28 ` [Qemu-devel] [PULL 04/21] qcow2-threads: qcow2_co_do_compress: protect queuing by mutex Max Reitz
2019-05-28 19:28 ` [Qemu-devel] [PULL 05/21] qcow2-threads: split out generic path Max Reitz
2019-05-28 19:28 ` [Qemu-devel] [PULL 06/21] qcow2: qcow2_co_preadv: improve locking Max Reitz
2019-05-28 19:28 ` [Qemu-devel] [PULL 07/21] qcow2: bdrv_co_pwritev: move encryption code out of the lock Max Reitz
2019-05-28 19:28 ` [Qemu-devel] [PULL 08/21] qcow2: do encryption in threads Max Reitz
2019-05-28 19:28 ` [Qemu-devel] [PULL 09/21] block/backup: simplify backup_incremental_init_copy_bitmap Max Reitz
2019-05-28 19:28 ` [Qemu-devel] [PULL 10/21] block/backup: move to copy_bitmap with granularity Max Reitz
2019-05-28 19:28 ` [Qemu-devel] [PULL 11/21] block/backup: refactor and tolerate unallocated cluster skipping Max Reitz
2019-05-28 19:28 ` [Qemu-devel] [PULL 12/21] block/backup: unify different modes code path Max Reitz
2019-05-28 19:28 ` [Qemu-devel] [PULL 13/21] block/backup: refactor: split out backup_calculate_cluster_size Max Reitz
2019-05-28 19:28 ` [Qemu-devel] [PULL 14/21] block: Use bdrv_unref_child() for all children in bdrv_close() Max Reitz
2019-05-28 19:28 ` [Qemu-devel] [PULL 15/21] block: Make bdrv_root_attach_child() unref child_bs on failure Max Reitz
2019-05-28 19:28 ` [Qemu-devel] [PULL 16/21] qemu-img: rebase: Reuse parent BlockDriverState Max Reitz
2019-05-28 19:28 ` [Qemu-devel] [PULL 17/21] qemu-img: rebase: Reduce reads on in-chain rebase Max Reitz
2019-05-28 19:28 ` [Qemu-devel] [PULL 18/21] qemu-img: rebase: Reuse in-chain BlockDriverState Max Reitz
2019-05-28 19:28 ` [Qemu-devel] [PULL 19/21] qcow2: skip writing zero buffers to empty COW areas Max Reitz
2019-05-28 19:28 ` Max Reitz [this message]
2019-05-28 19:28 ` [Qemu-devel] [PULL 21/21] blockdev: loosen restrictions on drive-backup source node Max Reitz
2019-05-30 11:09 ` [Qemu-devel] [PULL 00/21] Block patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528192847.2730-21-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).