* [Qemu-devel] [PATCH] virtio-gpu: add sanity check
@ 2019-05-27 9:12 Gerd Hoffmann
2019-05-27 10:49 ` Marc-André Lureau
2019-05-29 3:09 ` Michael S. Tsirkin
0 siblings, 2 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2019-05-27 9:12 UTC (permalink / raw)
To: qemu-devel; +Cc: Michael S. Tsirkin, Gerd Hoffmann, tslabinski
Require a minimum 16x16 size for the scanout, to make sure the guest
can't set either width or height to zero. This (a) doesn't make sense
at all and (b) causes problems in some UI code. When using spice this
will triggers an assert().
Reported-by: Tyler Slabinski <tslabinski@slabity.net>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/display/virtio-gpu.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index 9e37e0ac96b7..372b31ef0af2 100644
--- a/hw/display/virtio-gpu.c
+++ b/hw/display/virtio-gpu.c
@@ -677,6 +677,8 @@ static void virtio_gpu_set_scanout(VirtIOGPU *g,
if (ss.r.x > res->width ||
ss.r.y > res->height ||
+ ss.r.width < 16 ||
+ ss.r.height < 16 ||
ss.r.width > res->width ||
ss.r.height > res->height ||
ss.r.x + ss.r.width > res->width ||
--
2.18.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] virtio-gpu: add sanity check
2019-05-27 9:12 [Qemu-devel] [PATCH] virtio-gpu: add sanity check Gerd Hoffmann
@ 2019-05-27 10:49 ` Marc-André Lureau
2019-05-29 3:09 ` Michael S. Tsirkin
1 sibling, 0 replies; 3+ messages in thread
From: Marc-André Lureau @ 2019-05-27 10:49 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: tslabinski, QEMU, Michael S. Tsirkin
On Mon, May 27, 2019 at 11:13 AM Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> Require a minimum 16x16 size for the scanout, to make sure the guest
> can't set either width or height to zero. This (a) doesn't make sense
> at all and (b) causes problems in some UI code. When using spice this
> will triggers an assert().
>
> Reported-by: Tyler Slabinski <tslabinski@slabity.net>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> hw/display/virtio-gpu.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
> index 9e37e0ac96b7..372b31ef0af2 100644
> --- a/hw/display/virtio-gpu.c
> +++ b/hw/display/virtio-gpu.c
> @@ -677,6 +677,8 @@ static void virtio_gpu_set_scanout(VirtIOGPU *g,
>
> if (ss.r.x > res->width ||
> ss.r.y > res->height ||
> + ss.r.width < 16 ||
> + ss.r.height < 16 ||
> ss.r.width > res->width ||
> ss.r.height > res->height ||
> ss.r.x + ss.r.width > res->width ||
> --
> 2.18.1
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-gpu: add sanity check
2019-05-27 9:12 [Qemu-devel] [PATCH] virtio-gpu: add sanity check Gerd Hoffmann
2019-05-27 10:49 ` Marc-André Lureau
@ 2019-05-29 3:09 ` Michael S. Tsirkin
1 sibling, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2019-05-29 3:09 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel, tslabinski
On Mon, May 27, 2019 at 11:12:26AM +0200, Gerd Hoffmann wrote:
> Require a minimum 16x16 size for the scanout, to make sure the guest
> can't set either width or height to zero. This (a) doesn't make sense
> at all and (b) causes problems in some UI code. When using spice this
> will triggers an assert().
>
> Reported-by: Tyler Slabinski <tslabinski@slabity.net>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
OK. Worth adding to spec maybe.
> ---
> hw/display/virtio-gpu.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
> index 9e37e0ac96b7..372b31ef0af2 100644
> --- a/hw/display/virtio-gpu.c
> +++ b/hw/display/virtio-gpu.c
> @@ -677,6 +677,8 @@ static void virtio_gpu_set_scanout(VirtIOGPU *g,
>
> if (ss.r.x > res->width ||
> ss.r.y > res->height ||
> + ss.r.width < 16 ||
> + ss.r.height < 16 ||
> ss.r.width > res->width ||
> ss.r.height > res->height ||
> ss.r.x + ss.r.width > res->width ||
> --
> 2.18.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-29 3:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-27 9:12 [Qemu-devel] [PATCH] virtio-gpu: add sanity check Gerd Hoffmann
2019-05-27 10:49 ` Marc-André Lureau
2019-05-29 3:09 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).