From: Wei Yang <richardw.yang@linux.intel.com>
To: Juan Quintela <quintela@redhat.com>
Cc: Wei Yang <richardw.yang@linux.intel.com>,
dgilbert@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/4] migration/ram.c: MultiFDSendParams.sem_sync is not really used
Date: Wed, 29 May 2019 08:40:15 +0800 [thread overview]
Message-ID: <20190529004015.GD24428@richard> (raw)
In-Reply-To: <87ef4j8055.fsf@trasno.org>
On Tue, May 28, 2019 at 10:16:06AM +0200, Juan Quintela wrote:
>Wei Yang <richardw.yang@linux.intel.com> wrote:
>> Besides init and destroy, MultiFDSendParams.sem_sync is not really used.
>>
>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>
>Reviewed-by: Juan Quintela <quintela@redhat.com>
>
>I mad SendParamas and RecvParams identical, but they are different. You
>are right.
Thanks.
BTW, I found some interesting thing about multifd_send_state->channels_ready.
By checking the value of this semaphore, it grows far beyond what we really
have.
For example, we have default 2 channels which means
multifd_send_state->channels_ready's value is no more than 2. But the actual
value could go to more than 30.
The behavior sounds not right.
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2019-05-29 0:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 1:46 [Qemu-devel] [PATCH 0/4] Multifd Cleanup Wei Yang
2019-05-28 1:47 ` [Qemu-devel] [PATCH 1/4] migration: multifd_save_setup always return 0 Wei Yang
2019-05-28 8:11 ` Juan Quintela
2019-05-29 0:34 ` Wei Yang
2019-05-29 8:22 ` Juan Quintela
2019-05-29 8:22 ` Juan Quintela
2019-05-28 1:47 ` [Qemu-devel] [PATCH 2/4] migration/ram.c: use same type in MultiFDPages_t to define offsest Wei Yang
2019-05-28 8:12 ` Juan Quintela
2019-05-29 0:34 ` Wei Yang
2019-05-28 1:47 ` [Qemu-devel] [PATCH 3/4] migration/ram.c: MultiFDSendParams.sem_sync is not really used Wei Yang
2019-05-28 8:16 ` Juan Quintela
2019-05-29 0:40 ` Wei Yang [this message]
2019-05-28 1:47 ` [Qemu-devel] [PATCH 4/4] migration/ram.c: multifd_send_state->count " Wei Yang
2019-05-28 8:19 ` Juan Quintela
2019-06-04 2:25 ` [Qemu-devel] [PATCH 0/4] Multifd Cleanup Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529004015.GD24428@richard \
--to=richardw.yang@linux.intel.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).