From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B488C04AB3 for ; Wed, 29 May 2019 04:04:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5162621734 for ; Wed, 29 May 2019 04:04:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.b="eGksVjai" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5162621734 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:46657 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVppZ-0004vJ-GM for qemu-devel@archiver.kernel.org; Wed, 29 May 2019 00:04:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVpom-0004cT-27 for qemu-devel@nongnu.org; Wed, 29 May 2019 00:04:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVpok-0006xh-EV for qemu-devel@nongnu.org; Wed, 29 May 2019 00:03:59 -0400 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:50847 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hVpoi-0006lo-R1 for qemu-devel@nongnu.org; Wed, 29 May 2019 00:03:58 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 45DHBg1vMSz9sB8; Wed, 29 May 2019 14:03:39 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1559102619; bh=/luALfeC8x0Y7FPALvUo4G9a2dSAY/XJEm5Z3sU6+iI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eGksVjaic0ycB2ECzUGKIxoLvvWTfXlmi4ycotOhMslOnCqATIF8g61G9WXaVoQBx 9OdEt2zxcgRguV8Qad/lmNPWlxqA1romo7BUpLqHyst9hvRmvpcJyoxo2YynbekeD2 etK/MHxIIiFTknXeI7Yf1FwBKAjiVK8axwhQK5hU= Date: Wed, 29 May 2019 11:47:34 +1000 From: David Gibson To: Markus Armbruster Message-ID: <20190529014733.GA32028@umbus.fritz.box> References: <87lfyqla7r.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DocE+STaALJfprDB" Content-Disposition: inline In-Reply-To: <87lfyqla7r.fsf@dusky.pond.sub.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: Re: [Qemu-devel] Headers without multiple inclusion guards X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Chris Wulff , Sagar Karandikar , David Hildenbrand , James Hogan , Anthony Green , Palmer Dabbelt , Mark Cave-Ayland , qemu-devel@nongnu.org, Max Filippov , Dmitry Fleytman , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Guan Xuetao , Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Helge Deller , "Michael S. Tsirkin" , Laszlo Ersek , Halil Pasic , Christian Borntraeger , Anthony Perard , Jason Wang , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Riku Voipio , Eduardo Habkost , Alistair Francis , Greg Kurz , Marcelo Tosatti , Beniamino Galvani , Eric Auger , Paul Durrant , Stafford Horne , Alex =?iso-8859-1?Q?Benn=E9e?= , Richard Henderson , "Daniel P. Berrange" , Claudio Fontana , Bastian Koppelmann , Cornelia Huck , Claudio Fontana , Laurent Vivier , Andrew Baumann , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Michael Walle , Aleksandar Markovic , Paolo Bonzini , Aurelien Jarno , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --DocE+STaALJfprDB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 28, 2019 at 08:12:24PM +0200, Markus Armbruster wrote: > We have a bunch of headers without multiple inclusion guards. Some are > clearly intentional, some look accidental. Too many for me to find out > by examining each of them, so I'm asking their maintainers. >=20 > Why do I ask? I'd like to mark the intentional ones and fix the > accidental ones, so they don't flunk "make check-headers" from "[RFC v4 > 0/7] Baby steps towards saner headers" just because they lack multiple > inclusion guards. >=20 > Just in case: what's a multiple inclusion guard? It's >=20 > #ifndef UNIQUE_GUARD_SYMBOL_H > #define UNIQUE_GUARD_SYMBOL_H > ... > #endif >=20 > with nothing but comments outside the conditional, so that the header > can safely be included more than once. >=20 > I append the alphabetical list of headers without multiple inclusion > guards (as reported by scripts/clean-header-guards -nv), followed by the > same list sorted into maintainer buckets. If you're cc'ed, please find > your bucket(s), and tell me which headers intentionally lack guards. [snip] > PowerPC > M: David Gibson > target/ppc/helper.h Like the equivalent ARM variants, intentional. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --DocE+STaALJfprDB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAlzt5LUACgkQbDjKyiDZ s5KRHg/9EXoNGPwr+4nyw+b7H62dguDoiHNRG5msf4WewG/wlPrCft6eqcO8+/Kd PJtlqi6CNprLRoTrPLagGOC8R/GpZ7aWEFhshtqVheIlKS+80VCqAFdIejB/vr9a /f47qeNmKqMhEfEnJA332nqCOYY1niS+CnOV0+bd7psOQ6TlCnNvdPYYYdX3PXnS 9NTyacoPsWaR1/epuUBXck9WW1JeiNNLHuYN30arvjrcWifmVy5uWUeh2KRJwo5q 8eHzG00B5zQoJswbylAUYacesh+aGgFWVw6LU9Z1qu+gnXphXFfsRzguPcl4WUS9 F/oSKAweNcdAyAr7SzNFyYjsXJPC1SThspD6xN8qMgYyIFBpWmrciBJuD2EjsNzM OTgFGBnCmGazJ93j8J4mI5OwaZ1eqDkARhUmkT9H+wI1D8ac1lP6l+U7vFsC1xwc hLRdjR/JfCGfFcqD9e3k1J2bIgOJvaAWaISomBSx7cPeBYG+FJDOsWP+EurMhaaK 7La6D+8WH2GkX0w4HAgXIjgbXRbNK4jUCCd+3+BpUYQWdUrfODoTOixcuv3RaRo+ FiNuPbVSbA6rHw0jMo/oh0glvVjESUnfPNeoAj7e/Sqi0w7MOlop8lLrcl2JGdeO UoRC9vfijWBLkQw4jkhkwmo8jtGCjqJ3B4LTujjcZuBj3Th7Wx4= =u5pr -----END PGP SIGNATURE----- --DocE+STaALJfprDB--