From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, T_HK_NAME_DR,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FB53C28CC0 for ; Wed, 29 May 2019 09:10:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1765D2054F for ; Wed, 29 May 2019 09:10:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1765D2054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:50337 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVubE-00025a-91 for qemu-devel@archiver.kernel.org; Wed, 29 May 2019 05:10:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVuaO-0001mX-6G for qemu-devel@nongnu.org; Wed, 29 May 2019 05:09:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVuaM-0004hX-98 for qemu-devel@nongnu.org; Wed, 29 May 2019 05:09:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45788) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hVuaM-0004h0-3m for qemu-devel@nongnu.org; Wed, 29 May 2019 05:09:26 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F06F68831E for ; Wed, 29 May 2019 09:09:19 +0000 (UTC) Received: from work-vm (unknown [10.36.118.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B7E325D784; Wed, 29 May 2019 09:09:15 +0000 (UTC) Date: Wed, 29 May 2019 10:09:13 +0100 From: "Dr. David Alan Gilbert" To: Markus Armbruster Message-ID: <20190529090912.GC2882@work-vm> References: <20190523145840.11774-1-dgilbert@redhat.com> <20190523145840.11774-2-dgilbert@redhat.com> <87k1ehgm39.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k1ehgm39.fsf@dusky.pond.sub.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 29 May 2019 09:09:25 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 1/2] net/announce: Allow optional list of interfaces X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jasowang@redhat.com, qemu-devel@nongnu.org, laine@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Markus Armbruster (armbru@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" writes: > > > From: "Dr. David Alan Gilbert" > > > > Allow the caller to restrict the set of interfaces that announces are > > sent on. The default is still to send on all interfaces. > > > > e.g. > > > > { "execute": "announce-self", "arguments": { "initial": 50, "max": 550, "rounds": 5, "step": 50, "ifaces": ["vn2","vn1"] } } > > > > Note: There's still only one timer for the qmp command, so that > > performing an 'announce-self' on one list of interfaces followed > > by another 'announce-self' on another list will stop the announces > > on the existing set. > > > > Signed-off-by: Dr. David Alan Gilbert > [...] > > diff --git a/qapi/net.json b/qapi/net.json > > index 5f7bff1637..871cfa7405 100644 > > --- a/qapi/net.json > > +++ b/qapi/net.json > > @@ -706,7 +706,8 @@ > > 'data': { 'initial': 'int', > > 'max': 'int', > > 'rounds': 'int', > > - 'step': 'int' } } > > + 'step': 'int', > > + '*ifaces': ['str'] } } > > QMP traditionally eschews abbreviations like "iface". OK, renamed 'interfaces' Dave > > > > ## > > # @announce-self: > > @@ -718,9 +719,10 @@ > > # > > # Example: > > # > > -# -> { "execute": "announce-self" > > +# -> { "execute": "announce-self", > > # "arguments": { > > -# "initial": 50, "max": 550, "rounds": 10, "step": 50 } } > > +# "initial": 50, "max": 550, "rounds": 10, "step": 50, > > +# "ifaces": ["vn2","vn3"] } } > > # <- { "return": {} } > > # > > # Since: 4.0 -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK