From: Anthony PERARD <anthony.perard@citrix.com>
To: Markus Armbruster <armbru@redhat.com>,
Stefano Stabellini <sstabellini@kernel.org>
Cc: Paul Durrant <paul.durrant@citrix.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Headers without multiple inclusion guards
Date: Wed, 29 May 2019 10:58:23 +0100 [thread overview]
Message-ID: <20190529095823.GC2126@perard.uk.xensource.com> (raw)
In-Reply-To: <87lfyqla7r.fsf@dusky.pond.sub.org>
On Tue, May 28, 2019 at 08:12:24PM +0200, Markus Armbruster wrote:
> Just in case: what's a multiple inclusion guard? It's
>
> #ifndef UNIQUE_GUARD_SYMBOL_H
> #define UNIQUE_GUARD_SYMBOL_H
> ...
> #endif
>
> with nothing but comments outside the conditional, so that the header
> can safely be included more than once.
> Guest CPU Cores (Xen):
> ----------------------
>
> X86
> M: Stefano Stabellini <sstabellini@kernel.org>
> M: Anthony Perard <anthony.perard@citrix.com>
> M: Paul Durrant <paul.durrant@citrix.com>
> include/hw/xen/io/ring.h
That file does have a guard, it's __XEN_PUBLIC_IO_RING_H__
Do you (or the checker) want it to be changed to XEN_PUBLIC_IO_RING_H ?
> virtio-9p
> M: Greg Kurz <groug@kaod.org>
> hw/9pfs/xen-9pfs.h
Stefano, is the missing inclusion guard was intentional? Otherwise, I
can send a patch for it.
Cheers,
--
Anthony PERARD
next prev parent reply other threads:[~2019-05-29 9:59 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 18:12 [Qemu-devel] Headers without multiple inclusion guards Markus Armbruster
2019-05-28 18:32 ` Peter Maydell
2019-05-29 12:47 ` Markus Armbruster
2019-05-30 10:14 ` Peter Maydell
2019-05-28 19:23 ` Eduardo Habkost
2019-05-29 8:21 ` Paul Durrant
2019-05-29 12:49 ` Markus Armbruster
2019-05-28 19:55 ` Max Filippov
2019-05-29 12:51 ` Markus Armbruster
2019-05-29 13:20 ` Philippe Mathieu-Daudé
2019-05-28 20:08 ` Richard Henderson
2019-05-28 22:14 ` BALATON Zoltan
2019-05-29 1:47 ` David Gibson
2019-05-29 6:30 ` Laurent Vivier
2019-05-29 8:25 ` Bastian Koppelmann
2019-05-29 9:01 ` Cornelia Huck
2019-05-29 9:19 ` Greg Kurz
2019-05-29 9:38 ` Alex Bennée
2019-05-29 9:58 ` Anthony PERARD [this message]
2019-05-29 12:55 ` Markus Armbruster
2019-05-29 10:05 ` David Hildenbrand
2019-05-29 13:22 ` Philippe Mathieu-Daudé
2019-05-29 14:10 ` Markus Armbruster
2019-06-03 10:57 ` Laszlo Ersek
2019-06-02 7:06 ` Dmitry Fleytman
2019-06-03 10:55 ` Laszlo Ersek
2019-06-03 12:59 ` Markus Armbruster
2019-06-03 14:24 ` Philippe Mathieu-Daudé
2019-06-03 16:23 ` Laszlo Ersek
2019-06-05 14:23 ` Daniel P. Berrangé
2019-06-05 16:18 ` Laszlo Ersek
2019-06-05 16:23 ` Daniel P. Berrangé
2019-06-05 17:03 ` Laszlo Ersek
2019-06-05 17:52 ` Markus Armbruster
2019-06-07 17:32 ` Daniel P. Berrangé
2019-06-05 20:49 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529095823.GC2126@perard.uk.xensource.com \
--to=anthony.perard@citrix.com \
--cc=armbru@redhat.com \
--cc=paul.durrant@citrix.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).