From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BED1C28CC0 for ; Wed, 29 May 2019 16:04:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4494F23CBC for ; Wed, 29 May 2019 16:04:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4494F23CBC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:57293 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hW13g-0007gZ-7o for qemu-devel@archiver.kernel.org; Wed, 29 May 2019 12:04:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59330) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hW113-0005oM-Bj for qemu-devel@nongnu.org; Wed, 29 May 2019 12:01:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hW110-0006wQ-2Q for qemu-devel@nongnu.org; Wed, 29 May 2019 12:01:25 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:38562) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hW10y-0006uZ-2f for qemu-devel@nongnu.org; Wed, 29 May 2019 12:01:21 -0400 Received: by mail-qt1-f194.google.com with SMTP id l3so3235432qtj.5 for ; Wed, 29 May 2019 09:01:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=S7F71fn4zSn16Q9Ax37HUxslboQHMio1avV0U+I8iLg=; b=S2EDmEG+eS4IRrl/56ALrujd86ia1SEX3essS1CySWllqxnrhqR+9Vq40Xy4mzIdp1 OAZKlScnWq5Yvx/GxS8Ffixcvio3V0/SCAyK7hAAh8NRgv0LP6TzjXsb6aHLCkc1XHOQ uVk4F7hZoq9jp/ZtK3QIsjp1YVNC6YQsx4+JFGPvja5e3Ox6LgLWccmJ0SfrjKDOc4cf XvkR8r7WVhmLvU0vb64DRqN7GYmCvuV51lAxi7f1WM9HXU9VYlpLFpx9FEWBYS6SWxLs 2TV7QILmq8S9WrS9jS6Zkj79NFmaWg67E8OKvj/vt2Ww/1tz4jx3ntF92/qHBEE68H01 pDDQ== X-Gm-Message-State: APjAAAV9t+x2CaVvEmSsNpT/lcvnnSkUEqurtZdrmJNIauOetizMhJKX 70iV0CD0UFSzJ7GkmdXQDj3PrA== X-Google-Smtp-Source: APXvYqyFpe4VlmLLgMiuiE0hMqpZEuT3UGLw2TlHK0bZEVl90/YIoTk5CwPZmURbuaNiVZV5ML506Q== X-Received: by 2002:ac8:2906:: with SMTP id y6mr89916596qty.138.1559145677284; Wed, 29 May 2019 09:01:17 -0700 (PDT) Received: from redhat.com (pool-100-0-197-103.bstnma.fios.verizon.net. [100.0.197.103]) by smtp.gmail.com with ESMTPSA id g20sm6104857qkm.89.2019.05.29.09.01.15 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 29 May 2019 09:01:16 -0700 (PDT) Date: Wed, 29 May 2019 12:01:14 -0400 From: "Michael S. Tsirkin" To: Alex Williamson Message-ID: <20190529120043-mutt-send-email-mst@kernel.org> References: <155786484688.13873.6037015630912983760.stgit@gimli.home> <20190528232626-mutt-send-email-mst@kernel.org> <20190529074356.29ab0f7a@x1.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190529074356.29ab0f7a@x1.home> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.160.194 Subject: Re: [Qemu-devel] [PATCH for-4.1 v2] q35: Revert to kernel irqchip X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: berrange@redhat.com, ehabkost@redhat.com, qemu-devel@nongnu.org, peterx@redhat.com, pbonzini@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, May 29, 2019 at 07:43:56AM -0600, Alex Williamson wrote: > On Tue, 28 May 2019 23:30:20 -0400 > "Michael S. Tsirkin" wrote: > > > On Tue, May 14, 2019 at 02:14:41PM -0600, Alex Williamson wrote: > > > Commit b2fc91db8447 ("q35: set split kernel irqchip as default") changed > > > the default for the pc-q35-4.0 machine type to use split irqchip, which > > > turned out to have disasterous effects on vfio-pci INTx support. KVM > > > resampling irqfds are registered for handling these interrupts, but > > > these are non-functional in split irqchip mode. We can't simply test > > > for split irqchip in QEMU as userspace handling of this interrupt is a > > > significant performance regression versus KVM handling (GeForce GPUs > > > assigned to Windows VMs are non-functional without forcing MSI mode or > > > re-enabling kernel irqchip). > > > > > > The resolution is to revert the change in default irqchip mode in the > > > pc-q35-4.1 machine and create a pc-q35-4.0.1 machine for the 4.0-stable > > > branch. The qemu-q35-4.0 machine type should not be used in vfio-pci > > > configurations for devices requiring legacy INTx support without > > > explicitly modifying the VM configuration to use kernel irqchip. > > > > > > Link: https://bugs.launchpad.net/qemu/+bug/1826422 > > > Fixes: b2fc91db8447 ("q35: set split kernel irqchip as default") > > > Signed-off-by: Alex Williamson > > > > OK I guess but it's really a kvm patch. > > So I'd like Paolo to review and merge if appropriate. > > > > Can't say this makes me too happy. split irqchip > > has a bunch of advantages. > > What exactly are those advantages relative to a our default QEMU > users? I see lots of users assigning consumer class hardware and > seeing regressions. They don't care about a theoretically improved > security attack surface at the cost of performance for legacy devices, > or especially functionality. Should these users be our focus for the > default machine type? I think we could make these sorts of compromises > in a legacy-free or virt/cloud/enterprise machine type, but for a > general purpose PC emulator, it doesn't seem a good match given the > issues we have currently. Obviously users can continue to tune the q35 > machine type on their own and enable split irqchip if it's important to > them. Thanks, > > Alex It's a reasonable argument. Again I think Paolo should make the call. > > > --- > > > hw/core/machine.c | 3 +++ > > > hw/i386/pc.c | 3 +++ > > > hw/i386/pc_q35.c | 16 ++++++++++++++-- > > > include/hw/boards.h | 3 +++ > > > include/hw/i386/pc.h | 3 +++ > > > 5 files changed, 26 insertions(+), 2 deletions(-) > > > > > > diff --git a/hw/core/machine.c b/hw/core/machine.c > > > index 5d046a43e3d2..e41e6698ac9f 100644 > > > --- a/hw/core/machine.c > > > +++ b/hw/core/machine.c > > > @@ -24,6 +24,9 @@ > > > #include "hw/pci/pci.h" > > > #include "hw/mem/nvdimm.h" > > > > > > +GlobalProperty hw_compat_4_0_1[] = {}; > > > +const size_t hw_compat_4_0_1_len = G_N_ELEMENTS(hw_compat_4_0_1); > > > + > > > GlobalProperty hw_compat_4_0[] = {}; > > > const size_t hw_compat_4_0_len = G_N_ELEMENTS(hw_compat_4_0); > > > > > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > > > index d98b737b8f3b..b5311e7e2bd5 100644 > > > --- a/hw/i386/pc.c > > > +++ b/hw/i386/pc.c > > > @@ -115,6 +115,9 @@ struct hpet_fw_config hpet_cfg = {.count = UINT8_MAX}; > > > /* Physical Address of PVH entry point read from kernel ELF NOTE */ > > > static size_t pvh_start_addr; > > > > > > +GlobalProperty pc_compat_4_0_1[] = {}; > > > +const size_t pc_compat_4_0_1_len = G_N_ELEMENTS(pc_compat_4_0_1); > > > + > > > GlobalProperty pc_compat_4_0[] = {}; > > > const size_t pc_compat_4_0_len = G_N_ELEMENTS(pc_compat_4_0); > > > > > > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > > > index 37dd350511a9..dcddc6466200 100644 > > > --- a/hw/i386/pc_q35.c > > > +++ b/hw/i386/pc_q35.c > > > @@ -357,7 +357,7 @@ static void pc_q35_machine_options(MachineClass *m) > > > m->units_per_default_bus = 1; > > > m->default_machine_opts = "firmware=bios-256k.bin"; > > > m->default_display = "std"; > > > - m->default_kernel_irqchip_split = true; > > > + m->default_kernel_irqchip_split = false; > > > m->no_floppy = 1; > > > machine_class_allow_dynamic_sysbus_dev(m, TYPE_AMD_IOMMU_DEVICE); > > > machine_class_allow_dynamic_sysbus_dev(m, TYPE_INTEL_IOMMU_DEVICE); > > > @@ -374,10 +374,22 @@ static void pc_q35_4_1_machine_options(MachineClass *m) > > > DEFINE_Q35_MACHINE(v4_1, "pc-q35-4.1", NULL, > > > pc_q35_4_1_machine_options); > > > > > > -static void pc_q35_4_0_machine_options(MachineClass *m) > > > +static void pc_q35_4_0_1_machine_options(MachineClass *m) > > > { > > > pc_q35_4_1_machine_options(m); > > > m->alias = NULL; > > > + compat_props_add(m->compat_props, hw_compat_4_0_1, hw_compat_4_0_1_len); > > > + compat_props_add(m->compat_props, pc_compat_4_0_1, pc_compat_4_0_1_len); > > > +} > > > + > > > +DEFINE_Q35_MACHINE(v4_0_1, "pc-q35-4.0.1", NULL, > > > + pc_q35_4_0_1_machine_options); > > > + > > > +static void pc_q35_4_0_machine_options(MachineClass *m) > > > +{ > > > + pc_q35_4_0_1_machine_options(m); > > > + m->default_kernel_irqchip_split = true; > > > + m->alias = NULL; > > > compat_props_add(m->compat_props, hw_compat_4_0, hw_compat_4_0_len); > > > compat_props_add(m->compat_props, pc_compat_4_0, pc_compat_4_0_len); > > > } > > > diff --git a/include/hw/boards.h b/include/hw/boards.h > > > index 6f7916f88f02..6ff02bf3e472 100644 > > > --- a/include/hw/boards.h > > > +++ b/include/hw/boards.h > > > @@ -292,6 +292,9 @@ struct MachineState { > > > } \ > > > type_init(machine_initfn##_register_types) > > > > > > +extern GlobalProperty hw_compat_4_0_1[]; > > > +extern const size_t hw_compat_4_0_1_len; > > > + > > > extern GlobalProperty hw_compat_4_0[]; > > > extern const size_t hw_compat_4_0_len; > > > > > > diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h > > > index 43df7230a22b..5d5636241e34 100644 > > > --- a/include/hw/i386/pc.h > > > +++ b/include/hw/i386/pc.h > > > @@ -293,6 +293,9 @@ int e820_add_entry(uint64_t, uint64_t, uint32_t); > > > int e820_get_num_entries(void); > > > bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *); > > > > > > +extern GlobalProperty pc_compat_4_0_1[]; > > > +extern const size_t pc_compat_4_0_1_len; > > > + > > > extern GlobalProperty pc_compat_4_0[]; > > > extern const size_t pc_compat_4_0_len; > > >