From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: philmd@redhat.com, ysato@users.sourceforge.jp
Subject: [Qemu-devel] [PATCH v16 11/23] target/rx: Convert to CPUClass::tlb_fill
Date: Fri, 31 May 2019 08:43:03 -0500 [thread overview]
Message-ID: <20190531134315.4109-12-richard.henderson@linaro.org> (raw)
In-Reply-To: <20190531134315.4109-1-richard.henderson@linaro.org>
The interface for tlb_fill has changed very recently.
Move the function into cpu.c so that it may be static
while assigning to the CPUClass methods.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/rx/cpu.c | 14 ++++++++++++++
target/rx/op_helper.c | 11 -----------
2 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/target/rx/cpu.c b/target/rx/cpu.c
index 4b96f2e463..3268077d08 100644
--- a/target/rx/cpu.c
+++ b/target/rx/cpu.c
@@ -143,6 +143,19 @@ static void rx_cpu_disas_set_info(CPUState *cpu, disassemble_info *info)
info->print_insn = print_insn_rx;
}
+static bool rx_cpu_tlb_fill(CPUState *cs, vaddr addr, int size,
+ MMUAccessType access_type, int mmu_idx,
+ bool probe, uintptr_t retaddr)
+{
+ uint32_t address, physical, prot;
+
+ /* Linear mapping */
+ address = physical = addr & TARGET_PAGE_MASK;
+ prot = PAGE_READ | PAGE_WRITE | PAGE_EXEC;
+ tlb_set_page(cs, address, physical, prot, mmu_idx, TARGET_PAGE_SIZE);
+ return true;
+}
+
static void rx_cpu_init(Object *obj)
{
CPUState *cs = CPU(obj);
@@ -177,6 +190,7 @@ static void rxcpu_class_init(ObjectClass *klass, void *data)
cc->get_phys_page_debug = rx_cpu_get_phys_page_debug;
cc->disas_set_info = rx_cpu_disas_set_info;
cc->tcg_initialize = rx_translate_init;
+ cc->tlb_fill = rx_cpu_tlb_fill;
cc->gdb_num_core_regs = 26;
}
diff --git a/target/rx/op_helper.c b/target/rx/op_helper.c
index 9a460070e9..fb7ae3c3ec 100644
--- a/target/rx/op_helper.c
+++ b/target/rx/op_helper.c
@@ -468,14 +468,3 @@ void QEMU_NORETURN helper_rxbrk(CPURXState *env)
{
raise_exception(env, 0x100, 0);
}
-
-void tlb_fill(CPUState *cs, target_ulong addr, int size,
- MMUAccessType access_type, int mmu_idx, uintptr_t retaddr)
-{
- uint32_t address, physical, prot;
-
- /* Linear mapping */
- address = physical = addr & TARGET_PAGE_MASK;
- prot = PAGE_READ | PAGE_WRITE | PAGE_EXEC;
- tlb_set_page(cs, address, physical, prot, mmu_idx, TARGET_PAGE_SIZE);
-}
--
2.17.1
next prev parent reply other threads:[~2019-05-31 14:01 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 13:42 [Qemu-devel] [PATCH v16 00/23] Add RX architecture Richard Henderson
2019-05-31 13:42 ` [Qemu-devel] [PATCH v16 01/23] target/rx: TCG translation Richard Henderson
2019-05-31 13:42 ` [Qemu-devel] [PATCH v16 02/23] target/rx: TCG helper Richard Henderson
2019-05-31 13:42 ` [Qemu-devel] [PATCH v16 03/23] target/rx: CPU definition Richard Henderson
2019-05-31 13:42 ` [Qemu-devel] [PATCH v16 04/23] target/rx: RX disassembler Richard Henderson
2019-05-31 13:42 ` [Qemu-devel] [PATCH v16 05/23] hw/intc: RX62N interrupt controller (ICUa) Richard Henderson
2019-05-31 13:42 ` [Qemu-devel] [PATCH v16 06/23] hw/timer: RX62N internal timer modules Richard Henderson
2019-05-31 13:42 ` [Qemu-devel] [PATCH v16 07/23] hw/char: RX62N serial communication interface (SCI) Richard Henderson
2019-05-31 13:43 ` [Qemu-devel] [PATCH v16 08/23] hw/rx: RX Target hardware definition Richard Henderson
2019-05-31 13:43 ` [Qemu-devel] [PATCH v16 09/23] qemu/bitops.h: Add extract8 and extract16 Richard Henderson
2019-05-31 13:43 ` [Qemu-devel] [PATCH v16 10/23] hw/registerfields.h: Add 8bit and 16bit register macros Richard Henderson
2019-05-31 13:43 ` Richard Henderson [this message]
2019-05-31 13:43 ` [Qemu-devel] [PATCH v16 12/23] target/rx: Add RX to SysEmuTarget Richard Henderson
2019-06-04 5:32 ` Philippe Mathieu-Daudé
2019-05-31 13:43 ` [Qemu-devel] [PATCH v16 13/23] target/rx: Fix cpu types and names Richard Henderson
2019-05-31 14:23 ` Igor Mammedov
2019-05-31 14:59 ` Richard Henderson
2019-05-31 15:15 ` Igor Mammedov
2019-05-31 13:43 ` [Qemu-devel] [PATCH v16 14/23] tests: Add rx to machine-none-test.c Richard Henderson
2019-06-04 5:33 ` Philippe Mathieu-Daudé
2019-05-31 13:43 ` [Qemu-devel] [PATCH v16 15/23] hw/rx: Honor -accel qtest Richard Henderson
2019-06-04 5:34 ` Philippe Mathieu-Daudé
2019-05-31 13:43 ` [Qemu-devel] [PATCH v16 16/23] Add rx-softmmu Richard Henderson
2019-06-04 6:38 ` Philippe Mathieu-Daudé
2019-06-04 14:25 ` Richard Henderson
2019-05-31 13:43 ` [Qemu-devel] [PATCH v16 17/23] MAINTAINERS: Add RX Richard Henderson
2019-05-31 13:43 ` [Qemu-devel] [PATCH v16 18/23] target/rx: Disassemble rx_index_addr into a string Richard Henderson
2019-05-31 13:43 ` [Qemu-devel] [PATCH v16 19/23] target/rx: Replace operand with prt_ldmi in disassembler Richard Henderson
2019-06-04 5:37 ` Philippe Mathieu-Daudé
2019-05-31 13:43 ` [Qemu-devel] [PATCH v16 20/23] target/rx: Use prt_ldmi for XCHG_mr disassembly Richard Henderson
2019-06-04 5:38 ` Philippe Mathieu-Daudé
2019-05-31 13:43 ` [Qemu-devel] [PATCH v16 21/23] target/rx: Emit all disassembly in one prt() Richard Henderson
2019-06-04 5:36 ` Philippe Mathieu-Daudé
2019-05-31 13:43 ` [Qemu-devel] [PATCH v16 22/23] target/rx: Collect all bytes during disassembly Richard Henderson
2019-06-04 5:41 ` Philippe Mathieu-Daudé
2019-05-31 13:43 ` [Qemu-devel] [PATCH v16 23/23] target/rx: Dump bytes for each insn " Richard Henderson
2019-06-04 5:35 ` Philippe Mathieu-Daudé
2019-05-31 14:12 ` [Qemu-devel] [PATCH v16 00/23] Add RX architecture no-reply
2019-06-04 5:23 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531134315.4109-12-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).