From: Cornelia Huck <cohuck@redhat.com>
To: Eric Farman <farman@linux.ibm.com>
Cc: Pierre Morel <pmorel@linux.ibm.com>,
Farhan Ali <alifm@linux.ibm.com>,
Alex Williamson <alex.williamson@redhat.com>,
qemu-devel@nongnu.org, Halil Pasic <pasic@linux.ibm.com>,
qemu-s390x@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 2/2] vfio-ccw: support async command subregion
Date: Fri, 31 May 2019 14:42:19 +0200 [thread overview]
Message-ID: <20190531144219.75e4dc39.cohuck@redhat.com> (raw)
In-Reply-To: <5cee6204-3106-9a99-3620-aa8f4df491aa@linux.ibm.com>
On Wed, 29 May 2019 09:47:57 -0400
Eric Farman <farman@linux.ibm.com> wrote:
> On 5/7/19 11:47 AM, Cornelia Huck wrote:
> > A vfio-ccw device may provide an async command subregion for
> > issuing halt/clear subchannel requests. If it is present, use
> > it for sending halt/clear request to the device; if not, fall
> > back to emulation (as done today).
> >
> > Signed-off-by: Cornelia Huck <cohuck@redhat.com>
>
> This looks fine to me; thanks for the explanations!
>
> Reviewed-by: Eric Farman <farman@linux.ibm.com>
>
> > ---
> > hw/s390x/css.c | 27 +++++++--
> > hw/vfio/ccw.c | 110 +++++++++++++++++++++++++++++++++++-
> > include/hw/s390x/s390-ccw.h | 3 +
> > 3 files changed, 134 insertions(+), 6 deletions(-)
Thanks for your review!
Queued to s390-next.
prev parent reply other threads:[~2019-05-31 12:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 15:47 [Qemu-devel] [PATCH v4 0/2] vfio-ccw: support hsch/csch (QEMU part) Cornelia Huck
2019-05-07 15:47 ` [Qemu-devel] [PATCH v4 1/2] linux-headers: update Cornelia Huck
2019-05-07 15:47 ` [Qemu-devel] [PATCH v4 2/2] vfio-ccw: support async command subregion Cornelia Huck
2019-05-20 8:42 ` Cornelia Huck
2019-05-20 16:30 ` Eric Farman
2019-05-20 16:29 ` Eric Farman
2019-05-20 16:47 ` Cornelia Huck
2019-05-21 16:32 ` Cornelia Huck
2019-05-21 20:47 ` Eric Farman
2019-05-29 9:48 ` Cornelia Huck
2019-05-29 13:47 ` Eric Farman
2019-05-21 20:51 ` Farhan Ali
2019-05-22 10:13 ` Cornelia Huck
2019-05-21 20:50 ` Farhan Ali
2019-05-22 10:17 ` Cornelia Huck
2019-05-22 11:53 ` Farhan Ali
2019-05-29 13:47 ` Eric Farman
2019-05-31 12:42 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531144219.75e4dc39.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=alifm@linux.ibm.com \
--cc=farman@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).