qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	peterx@redhat.com, Juan Quintela <quintela@redhat.com>
Subject: [Qemu-devel] [PATCH v4 02/11] memory: Remove memory_region_get_dirty()
Date: Mon,  3 Jun 2019 14:50:47 +0800	[thread overview]
Message-ID: <20190603065056.25211-3-peterx@redhat.com> (raw)
In-Reply-To: <20190603065056.25211-1-peterx@redhat.com>

It's never used anywhere.

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
 include/exec/memory.h | 17 -----------------
 memory.c              |  8 --------
 2 files changed, 25 deletions(-)

diff --git a/include/exec/memory.h b/include/exec/memory.h
index 9144a47f57..e6140e8a04 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -1254,23 +1254,6 @@ void memory_region_ram_resize(MemoryRegion *mr, ram_addr_t newsize,
  */
 void memory_region_set_log(MemoryRegion *mr, bool log, unsigned client);
 
-/**
- * memory_region_get_dirty: Check whether a range of bytes is dirty
- *                          for a specified client.
- *
- * Checks whether a range of bytes has been written to since the last
- * call to memory_region_reset_dirty() with the same @client.  Dirty logging
- * must be enabled.
- *
- * @mr: the memory region being queried.
- * @addr: the address (relative to the start of the region) being queried.
- * @size: the size of the range being queried.
- * @client: the user of the logging information; %DIRTY_MEMORY_MIGRATION or
- *          %DIRTY_MEMORY_VGA.
- */
-bool memory_region_get_dirty(MemoryRegion *mr, hwaddr addr,
-                             hwaddr size, unsigned client);
-
 /**
  * memory_region_set_dirty: Mark a range of bytes as dirty in a memory region.
  *
diff --git a/memory.c b/memory.c
index 3071c4bdad..0920c105aa 100644
--- a/memory.c
+++ b/memory.c
@@ -2027,14 +2027,6 @@ void memory_region_set_log(MemoryRegion *mr, bool log, unsigned client)
     memory_region_transaction_commit();
 }
 
-bool memory_region_get_dirty(MemoryRegion *mr, hwaddr addr,
-                             hwaddr size, unsigned client)
-{
-    assert(mr->ram_block);
-    return cpu_physical_memory_get_dirty(memory_region_get_ram_addr(mr) + addr,
-                                         size, client);
-}
-
 void memory_region_set_dirty(MemoryRegion *mr, hwaddr addr,
                              hwaddr size)
 {
-- 
2.17.1



  parent reply	other threads:[~2019-06-03  6:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-03  6:50 [Qemu-devel] [PATCH v4 00/11] kvm/migration: support KVM_CLEAR_DIRTY_LOG Peter Xu
2019-06-03  6:50 ` [Qemu-devel] [PATCH v4 01/11] migration: No need to take rcu during sync_dirty_bitmap Peter Xu
2019-06-03  6:50 ` Peter Xu [this message]
2019-06-03  6:50 ` [Qemu-devel] [PATCH v4 03/11] memory: Don't set migration bitmap when without migration Peter Xu
2019-06-03  6:50 ` [Qemu-devel] [PATCH v4 04/11] bitmap: Add bitmap_copy_with_{src|dst}_offset() Peter Xu
2019-06-03  9:30   ` Dr. David Alan Gilbert
2019-06-03  6:50 ` [Qemu-devel] [PATCH v4 05/11] memory: Pass mr into snapshot_and_clear_dirty Peter Xu
2019-06-03  9:36   ` Dr. David Alan Gilbert
2019-06-03  6:50 ` [Qemu-devel] [PATCH v4 06/11] memory: Introduce memory listener hook log_clear() Peter Xu
2019-06-03  6:50 ` [Qemu-devel] [PATCH v4 07/11] kvm: Update comments for sync_dirty_bitmap Peter Xu
2019-06-03  6:50 ` [Qemu-devel] [PATCH v4 08/11] kvm: Persistent per kvmslot dirty bitmap Peter Xu
2019-06-03  9:49   ` Dr. David Alan Gilbert
2019-06-03  6:50 ` [Qemu-devel] [PATCH v4 09/11] kvm: Introduce slots lock for memory listener Peter Xu
2019-06-03  6:50 ` [Qemu-devel] [PATCH v4 10/11] kvm: Support KVM_CLEAR_DIRTY_LOG Peter Xu
2019-06-03  6:50 ` [Qemu-devel] [PATCH v4 11/11] migration: Split log_clear() into smaller chunks Peter Xu
2019-06-03  9:57   ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190603065056.25211-3-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).