qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH 0/2] blockdev: Overlays are not snapshots
@ 2019-06-03 16:25 Max Reitz
  2019-06-03 16:25 ` [Qemu-devel] [PATCH 1/2] qapi/block-core: " Max Reitz
  2019-06-03 16:25 ` [Qemu-devel] [PATCH 2/2] blockdev: " Max Reitz
  0 siblings, 2 replies; 6+ messages in thread
From: Max Reitz @ 2019-06-03 16:25 UTC (permalink / raw)
  To: qemu-block; +Cc: Kevin Wolf, Markus Armbruster, qemu-devel, Max Reitz

QEMU’s always been confused over what a snapshot is: Is it the overlay?
Is it the backing image?

Confusion is rarely a good thing.  I can’t think of any objective reason
why the overlay would be a snapshot.  A snapshot is something that does
not change over time; the overlay does.

(I suppose historically the reason is that “Taking an overlay” makes no
sense, so the operations are called “Taking a snapshot”.  Somehow, this
meaning carried over to the new file that is created during that
operation; if “Creating a snapshot” creates a file, that file must be
the snapshot, right?  Well, no, it isn’t.)

Let’s fix this as best as we can.  Better Nate than lever.


Mae Reitz (2):
  qapi/block-core: Overlays are not snapshots
  blockdev: Overlays are not snapshots

 qapi/block-core.json | 20 ++++++++++----------
 blockdev.c           | 10 +++++-----
 2 files changed, 15 insertions(+), 15 deletions(-)

-- 
2.21.0



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-06-03 20:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-03 16:25 [Qemu-devel] [PATCH 0/2] blockdev: Overlays are not snapshots Max Reitz
2019-06-03 16:25 ` [Qemu-devel] [PATCH 1/2] qapi/block-core: " Max Reitz
2019-06-03 19:42   ` Eric Blake
2019-06-03 16:25 ` [Qemu-devel] [PATCH 2/2] blockdev: " Max Reitz
2019-06-03 19:42   ` Eric Blake
2019-06-03 20:07   ` Max Reitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).