* [Qemu-devel] [PATCH] decodetree: Fix comparison of Field
@ 2019-06-04 15:42 Richard Henderson
2019-06-04 16:12 ` Peter Maydell
2019-06-11 11:38 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Richard Henderson @ 2019-06-04 15:42 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell
Typo comparing the sign of the field, twice, instead of also comparing
the mask of the field (which itself encodes both position and length).
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
scripts/decodetree.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/decodetree.py b/scripts/decodetree.py
index 81874e22cc..d7a59d63ac 100755
--- a/scripts/decodetree.py
+++ b/scripts/decodetree.py
@@ -184,7 +184,7 @@ class Field:
return '{0}(insn, {1}, {2})'.format(extr, self.pos, self.len)
def __eq__(self, other):
- return self.sign == other.sign and self.sign == other.sign
+ return self.sign == other.sign and self.mask == other.mask
def __ne__(self, other):
return not self.__eq__(other)
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] decodetree: Fix comparison of Field
2019-06-04 15:42 [Qemu-devel] [PATCH] decodetree: Fix comparison of Field Richard Henderson
@ 2019-06-04 16:12 ` Peter Maydell
2019-06-11 11:38 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2019-06-04 16:12 UTC (permalink / raw)
To: Richard Henderson; +Cc: QEMU Developers
On Tue, 4 Jun 2019 at 16:42, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Typo comparing the sign of the field, twice, instead of also comparing
> the mask of the field (which itself encodes both position and length).
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> scripts/decodetree.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/decodetree.py b/scripts/decodetree.py
> index 81874e22cc..d7a59d63ac 100755
> --- a/scripts/decodetree.py
> +++ b/scripts/decodetree.py
> @@ -184,7 +184,7 @@ class Field:
> return '{0}(insn, {1}, {2})'.format(extr, self.pos, self.len)
>
> def __eq__(self, other):
> - return self.sign == other.sign and self.sign == other.sign
> + return self.sign == other.sign and self.mask == other.mask
>
> def __ne__(self, other):
> return not self.__eq__(other)
> --
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
This fixes the problems I was seeing with the VFP decodetree
conversion I was working on.
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] decodetree: Fix comparison of Field
2019-06-04 15:42 [Qemu-devel] [PATCH] decodetree: Fix comparison of Field Richard Henderson
2019-06-04 16:12 ` Peter Maydell
@ 2019-06-11 11:38 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-06-11 11:38 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: peter.maydell
On 6/4/19 5:42 PM, Richard Henderson wrote:
> Typo comparing the sign of the field, twice, instead of also comparing
> the mask of the field (which itself encodes both position and length).
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> scripts/decodetree.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/decodetree.py b/scripts/decodetree.py
> index 81874e22cc..d7a59d63ac 100755
> --- a/scripts/decodetree.py
> +++ b/scripts/decodetree.py
> @@ -184,7 +184,7 @@ class Field:
> return '{0}(insn, {1}, {2})'.format(extr, self.pos, self.len)
>
> def __eq__(self, other):
> - return self.sign == other.sign and self.sign == other.sign
> + return self.sign == other.sign and self.mask == other.mask
Argh
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> def __ne__(self, other):
> return not self.__eq__(other)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-11 11:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-04 15:42 [Qemu-devel] [PATCH] decodetree: Fix comparison of Field Richard Henderson
2019-06-04 16:12 ` Peter Maydell
2019-06-11 11:38 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).