[Qemu-devel] [PATCH] iotests: restrict 254 to support only qcow2

[Qemu-devel] [PATCH] iotests: restrict 254 to support only qcow2

[Vladimir Sementsov-Ogievskiy]

Test fails at least for qcow, because of different cluster sizes in
base and top (and therefore different granularities of bitmaps we are
trying to merge).

The test aim is to check block-dirty-bitmap-merge between different
nodes functionality, no needs to check all formats. So, let's just drop
support for anything except qcow2.

Reported-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 tests/qemu-iotests/254 | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/qemu-iotests/254 b/tests/qemu-iotests/254
index 33cb80a512..8edba91c5d 100755
--- a/tests/qemu-iotests/254
+++ b/tests/qemu-iotests/254
@@ -21,6 +21,8 @@
 import iotests
 from iotests import qemu_img_create, file_path, log
 
+iotests.verify_image_format(supported_fmts=['qcow2'])
+
 disk, top = file_path('disk', 'top')
 size = 1024 * 1024
 
-- 
2.18.0

Re: [Qemu-devel] [PATCH] iotests: restrict 254 to support only qcow2

[Max Reitz]

[-- Attachment #1: Type: text/plain, Size: 719 bytes --]

On 05.06.19 17:54, Vladimir Sementsov-Ogievskiy wrote:
> Test fails at least for qcow, because of different cluster sizes in
> base and top (and therefore different granularities of bitmaps we are
> trying to merge).
> 
> The test aim is to check block-dirty-bitmap-merge between different
> nodes functionality, no needs to check all formats. So, let's just drop
> support for anything except qcow2.
> 
> Reported-by: Max Reitz <mreitz@redhat.com>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>  tests/qemu-iotests/254 | 2 ++
>  1 file changed, 2 insertions(+)

Thanks, applied to my block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]