From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com,
den@openvz.org
Subject: Re: [Qemu-devel] [PATCH 1/2] io/channel: add qio_channel_set_keepalive
Date: Wed, 5 Jun 2019 17:07:34 +0100 [thread overview]
Message-ID: <20190605160734.GL8956@redhat.com> (raw)
In-Reply-To: <203f0c03-12bb-5e8d-7615-f820c2a01cba@redhat.com>
On Wed, Jun 05, 2019 at 09:38:06AM -0500, Eric Blake wrote:
> On 6/5/19 5:09 AM, Vladimir Sementsov-Ogievskiy wrote:
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > ---
> > include/io/channel.h | 13 +++++++++++++
> > io/channel-socket.c | 19 +++++++++++++++++++
> > io/channel.c | 14 ++++++++++++++
> > 3 files changed, 46 insertions(+)
>
> Dan, if you'd like, I can take this through my NBD tree.
>
> Reviewed-by: Eric Blake <eblake@redhat.com
There's a couple of small tweaks needed, but if you apply those then
consider it to have my Acked-by: Daniel P. Berrangé <berrange@redhat.com>
for you to merge directly.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2019-06-05 16:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 10:09 [Qemu-devel] [PATCH 0/2] nbd: enable keepalive Vladimir Sementsov-Ogievskiy
2019-06-05 10:09 ` [Qemu-devel] [PATCH 1/2] io/channel: add qio_channel_set_keepalive Vladimir Sementsov-Ogievskiy
2019-06-05 14:38 ` Eric Blake
2019-06-05 16:07 ` Daniel P. Berrangé [this message]
2019-06-05 16:02 ` Daniel P. Berrangé
2019-06-05 16:10 ` Vladimir Sementsov-Ogievskiy
2019-06-05 10:09 ` [Qemu-devel] [PATCH 2/2] nbd-client: enable TCP keepalive Vladimir Sementsov-Ogievskiy
2019-06-05 14:39 ` Eric Blake
2019-06-05 14:43 ` Denis V. Lunev
2019-06-05 16:37 ` Daniel P. Berrangé
2019-06-05 17:05 ` Vladimir Sementsov-Ogievskiy
2019-06-05 17:12 ` Eric Blake
2019-06-05 17:28 ` Vladimir Sementsov-Ogievskiy
2019-06-05 17:36 ` Daniel P. Berrangé
2019-06-05 19:48 ` Eric Blake
2019-06-05 20:11 ` [Qemu-devel] nbd-server-add [was: [PATCH 2/2] nbd-client: enable TCP keepalive] Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605160734.GL8956@redhat.com \
--to=berrange@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).