qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Wei Yang <richardw.yang@linux.intel.com>
To: qemu-devel@nongnu.org
Cc: Wei Yang <richardw.yang@linux.intel.com>,
	dgilbert@redhat.com, quintela@redhat.com
Subject: [Qemu-devel] [PATCH 4/6] migration/multifd: used must not be 0 for a pending job
Date: Thu,  6 Jun 2019 16:34:59 +0800	[thread overview]
Message-ID: <20190606083501.2087-5-richardw.yang@linux.intel.com> (raw)
In-Reply-To: <20190606083501.2087-1-richardw.yang@linux.intel.com>

After thread synchronization request is handled in another case, this
means when we only get pending_job when there is used pages.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
 migration/ram.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/migration/ram.c b/migration/ram.c
index 9982930392..3e48795608 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1118,12 +1118,11 @@ static void *multifd_send_thread(void *opaque)
                 break;
             }
 
-            if (used) {
-                ret = qio_channel_writev_all(p->c, p->pages->iov,
+            assert(used);
+            ret = qio_channel_writev_all(p->c, p->pages->iov,
                                              used, &local_err);
-                if (ret != 0) {
-                    break;
-                }
+            if (ret != 0) {
+                break;
             }
 
             qemu_mutex_lock(&p->mutex);
-- 
2.19.1



  parent reply	other threads:[~2019-06-06  8:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-06  8:34 [Qemu-devel] [PATCH 0/6] multifd: a new mechanism for send thread sync Wei Yang
2019-06-06  8:34 ` [Qemu-devel] [PATCH 1/6] migration/multifd: move MultiFDSendParams handling into multifd_send_fill_packet() Wei Yang
2019-06-06  8:34 ` [Qemu-devel] [PATCH 2/6] migration/multifd: notify channels_ready when send thread starts Wei Yang
2019-06-06  8:34 ` [Qemu-devel] [PATCH 3/6] migration/multifd: use sync field to synchronize send threads Wei Yang
2019-06-06  8:34 ` Wei Yang [this message]
2019-06-06  8:35 ` [Qemu-devel] [PATCH 5/6] migration/multifd: use boolean for pending_job is enough Wei Yang
2019-06-06  8:35 ` [Qemu-devel] [PATCH 6/6] migration/multifd: there is no spurious wakeup now Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190606083501.2087-5-richardw.yang@linux.intel.com \
    --to=richardw.yang@linux.intel.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).