From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
"David Hildenbrand" <david@redhat.com>,
"Michael Tokarev" <mjt@tls.msk.ru>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Aleksandar Rikalo" <arikalo@wavecomp.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Yuval Shaia" <yuval.shaia@oracle.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-s390x@nongnu.org, "Cornelia Huck" <cohuck@redhat.com>,
"Laurent Vivier" <laurent@vivier.eu>,
qemu-trivial@nongnu.org, "Michael Walle" <michael@walle.cc>,
"Aleksandar Markovic" <amarkovic@wavecomp.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [Qemu-devel] [PULL 04/16] util: Adjust qemu_guest_getrandom_nofail for Coverity
Date: Thu, 6 Jun 2019 13:06:13 +0200 [thread overview]
Message-ID: <20190606110625.32127-5-laurent@vivier.eu> (raw)
In-Reply-To: <20190606110625.32127-1-laurent@vivier.eu>
From: Richard Henderson <richard.henderson@linaro.org>
Explicitly ignore the return value of qemu_guest_getrandom.
Because we use error_fatal, all errors are already caught.
Fixes: CID 1401701
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20190530173824.30699-1-richard.henderson@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
util/guest-random.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/guest-random.c b/util/guest-random.c
index e8124a3cad48..00a08fd9819c 100644
--- a/util/guest-random.c
+++ b/util/guest-random.c
@@ -56,7 +56,7 @@ int qemu_guest_getrandom(void *buf, size_t len, Error **errp)
void qemu_guest_getrandom_nofail(void *buf, size_t len)
{
- qemu_guest_getrandom(buf, len, &error_fatal);
+ (void)qemu_guest_getrandom(buf, len, &error_fatal);
}
uint64_t qemu_guest_random_seed_thread_part1(void)
--
2.21.0
next prev parent reply other threads:[~2019-06-06 11:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 11:06 [Qemu-devel] [PULL 00/16] Trivial branch patches Laurent Vivier
2019-06-06 11:06 ` [Qemu-devel] [PULL 01/16] hw/rdma: Delete unused headers inclusion Laurent Vivier
2019-06-06 11:06 ` [Qemu-devel] [PULL 02/16] migration: fix a typo Laurent Vivier
2019-06-06 11:06 ` [Qemu-devel] [PULL 03/16] vhost: fix incorrect print type Laurent Vivier
2019-06-06 11:06 ` Laurent Vivier [this message]
2019-06-06 11:06 ` [Qemu-devel] [PULL 05/16] test: Fix make target check-report.tap Laurent Vivier
2019-06-06 11:06 ` [Qemu-devel] [PULL 06/16] docs/devel/build-system: Update an example Laurent Vivier
2019-06-06 11:06 ` [Qemu-devel] [PULL 07/16] hw/scsi/vmw_pvscsi: Use qbus_reset_all() directly Laurent Vivier
2019-06-06 11:06 ` [Qemu-devel] [PULL 08/16] hw/pci-bridge: Use the QOM BUS() macro to access BusState.qbus Laurent Vivier
2019-06-06 11:06 ` [Qemu-devel] [PULL 09/16] hw/s390x/event-facility: " Laurent Vivier
2019-06-06 12:11 ` David Hildenbrand
2019-06-06 11:06 ` [Qemu-devel] [PULL 10/16] hw/isa: Use the QOM DEVICE() macro to access DeviceState.qdev Laurent Vivier
2019-06-06 11:06 ` [Qemu-devel] [PULL 11/16] hw/usb-storage: " Laurent Vivier
2019-06-06 11:06 ` [Qemu-devel] [PULL 12/16] hw/vfio/pci: " Laurent Vivier
2019-06-06 11:06 ` [Qemu-devel] [PULL 13/16] hw/audio/ac97: " Laurent Vivier
2019-06-06 11:06 ` [Qemu-devel] [PULL 14/16] hw/sd: Use the QOM BUS() macro to access BusState.qbus Laurent Vivier
2019-06-06 11:06 ` [Qemu-devel] [PULL 15/16] hw/scsi: " Laurent Vivier
2019-06-06 11:06 ` [Qemu-devel] [PULL 16/16] hw/watchdog/wdt_i6300esb: Use DEVICE() macro to access DeviceState.qdev Laurent Vivier
2019-06-06 14:04 ` [Qemu-devel] [PULL 00/16] Trivial branch patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606110625.32127-5-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=alex.williamson@redhat.com \
--cc=amarkovic@wavecomp.com \
--cc=arikalo@wavecomp.com \
--cc=berrange@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=dmitry.fleytman@gmail.com \
--cc=fam@euphon.net \
--cc=kraxel@redhat.com \
--cc=michael@walle.cc \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).