From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: pkrempa@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 4.5/6] qapi: Replace QAPIDoc._part by ._append_line, and rework comments
Date: Thu, 6 Jun 2019 15:21:39 +0200 [thread overview]
Message-ID: <20190606132139.GC9241@localhost.localdomain> (raw)
In-Reply-To: <87muiuhqh6.fsf_-_@dusky.pond.sub.org>
Am 06.06.2019 um 14:01 hat Markus Armbruster geschrieben:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> This is on top of the fixup I appended to my review of v4. I'd squash
> all three patches together.
>
> The next patch needs to be updated for this.
>
> Unsquashed branch at git://repo.or.cz/qemu/armbru.git branch
> qapi-features.
>
> Let me know what you think.
As you know, I don't like the self._append_line function pointer and
think it makes the code less readable. However, I also hope that I'll
never have to touch this code again, whereas you as the maintainer will
probably have to. So your taste is more imporant than mine.
So for all I care, go ahead and squash in your changes.
Kevin
next prev parent reply other threads:[~2019-06-06 13:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 11:02 [Qemu-devel] [PATCH v4 0/6] file-posix: Add dynamic-auto-read-only QAPI feature Kevin Wolf
2019-05-30 11:02 ` [Qemu-devel] [PATCH v4 1/6] qapi: Add feature flags to struct types Kevin Wolf
2019-05-30 11:02 ` [Qemu-devel] [PATCH v4 2/6] tests/qapi-schema: Test for good feature lists in structs Kevin Wolf
2019-05-30 11:02 ` [Qemu-devel] [PATCH v4 3/6] tests/qapi-schema: Error case tests for features " Kevin Wolf
2019-05-30 11:02 ` [Qemu-devel] [PATCH v4 4/6] qapi: Disentangle QAPIDoc code Kevin Wolf
2019-06-06 11:26 ` Markus Armbruster
2019-06-06 12:01 ` [Qemu-devel] [PATCH v4 4.5/6] qapi: Replace QAPIDoc._part by ._append_line, and rework comments Markus Armbruster
2019-06-06 13:21 ` Kevin Wolf [this message]
2019-05-30 11:02 ` [Qemu-devel] [PATCH v4 5/6] qapi: Allow documentation for features Kevin Wolf
2019-05-30 11:02 ` [Qemu-devel] [PATCH v4 6/6] file-posix: Add dynamic-auto-read-only QAPI feature Kevin Wolf
2019-06-06 14:27 ` [Qemu-devel] [PATCH v4 0/6] " Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606132139.GC9241@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).