From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7280DC04AB5 for ; Thu, 6 Jun 2019 17:49:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 455E220868 for ; Thu, 6 Jun 2019 17:49:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SiFVQbao" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 455E220868 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:35875 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYwVa-0005Wq-F7 for qemu-devel@archiver.kernel.org; Thu, 06 Jun 2019 13:49:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYwTi-00042p-Jv for qemu-devel@nongnu.org; Thu, 06 Jun 2019 13:47:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYwTg-0003Va-DI for qemu-devel@nongnu.org; Thu, 06 Jun 2019 13:47:05 -0400 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:52731) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hYwTf-0002mv-VK for qemu-devel@nongnu.org; Thu, 06 Jun 2019 13:47:04 -0400 Received: by mail-wm1-x343.google.com with SMTP id s3so802467wms.2 for ; Thu, 06 Jun 2019 10:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KtIfSIKYeaE77uLCULn8mRdtcD4iWxd4JC2TjSFb1R8=; b=SiFVQbaorp/ryzAfQvS9FdhoS3ZlfB/R7KNWo22KXM5RnAbfpAQzuVedj9rm29reWX Odpz2vu1fthyMOZtAktNuQVfn7MvDNHRIub81oqb9mMwfyoUiyBEVmx1otGtj2eUMrx0 O/5Uv+pnwe9L30Qg3kWlilCr+wVaDmgK9vU6Up9X1K0OcH5t9pd+JI+Oamg49eMcRO45 pAjhZI3T509giCCdxmrhOhA1YuKE9Zpr/W35+PDFLLInRnfG2ULB5cJ8HQWOwv9zWKsm xmok6zVVWJ9xxnMXSGR+f9icxays5c2xCsYCwl+/uEqZdk3Ivh1qLWYxBnADVsAGzFPR wnbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KtIfSIKYeaE77uLCULn8mRdtcD4iWxd4JC2TjSFb1R8=; b=iWPNnpBWcgeCfGidiSemg/QzFTSx1uVVsP5KXAEoWvQuFLSNtGCNtwMXfudGjLVxqy Rkzga9u2xrN6eqBnBmf3ctS+2eNYkSkjN1wiXVfGLADdsEQ1DS8/D0wlSV9Zz21jLGRt Apz8m1eQmPBJIp5XeHhUCxzdYHpXKMFqtzKz7ySlYwHwBEq3kFVt2vD8eFVtiuZItAnb t6JhtC054FPFUrgFvp5Rt9umHLkyMwbWWagVIH5JIv2PU7S2IDxquwhcyoERJmcZyG60 AEDbXfvoF/MeH3C7f1tkEVum2naZuL/jz3SH1ftmjhYH5PfHoikEnWdQk4+7AiPjJN+s zwIw== X-Gm-Message-State: APjAAAXZHnz05xhDZphynUrZMNkmRqjWRILh8y/WtuBJqDOLSCA+D+fG NJinQZwQMwh5DK8nWMs0mSVXSADivofigw== X-Google-Smtp-Source: APXvYqzXshMuRQGP88bBQ+eq4SsY5oa2Rnl05O4Z+qQEI8N9BgO06AkZtIQQFLu6eq9IcTPe2ZoZzQ== X-Received: by 2002:a1c:cfc3:: with SMTP id f186mr759827wmg.134.1559843172539; Thu, 06 Jun 2019 10:46:12 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id z135sm2596784wmc.45.2019.06.06.10.46.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Jun 2019 10:46:11 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Date: Thu, 6 Jun 2019 18:45:28 +0100 Message-Id: <20190606174609.20487-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190606174609.20487-1-peter.maydell@linaro.org> References: <20190606174609.20487-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::343 Subject: [Qemu-devel] [PATCH 01/42] decodetree: Fix comparison of Field X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson Typo comparing the sign of the field, twice, instead of also comparing the mask of the field (which itself encodes both position and length). Reported-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20190604154225.26992-1-richard.henderson@linaro.org Signed-off-by: Peter Maydell --- scripts/decodetree.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/decodetree.py b/scripts/decodetree.py index 81874e22cc7..d7a59d63ac3 100755 --- a/scripts/decodetree.py +++ b/scripts/decodetree.py @@ -184,7 +184,7 @@ class Field: return '{0}(insn, {1}, {2})'.format(extr, self.pos, self.len) def __eq__(self, other): - return self.sign == other.sign and self.sign == other.sign + return self.sign == other.sign and self.mask == other.mask def __ne__(self, other): return not self.__eq__(other) -- 2.20.1