From: Cleber Rosa <crosa@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Samuel Ortiz" <sameo@linux.intel.com>
Subject: [Qemu-devel] [PATCH v6 1/7] Acceptance tests: use relative location for tests
Date: Thu, 6 Jun 2019 17:14:08 -0400 [thread overview]
Message-ID: <20190606211414.8681-2-crosa@redhat.com> (raw)
In-Reply-To: <20190606211414.8681-1-crosa@redhat.com>
An Avocado Test ID[1] is composed by a number of components, but it
starts with the Test Name, usually a file system location that was
given to the loader.
Because the source directory is being given as a prefix to the
"tests/acceptance" directory containing the acceptance tests, the test
names will needlessly include the directory the user is using to host
the QEMU sources (and/or build tree).
Let's remove the source dir (or a build dir) from the path given to
the test loader. This should give more constant names, and when using
result servers and databases, it should give the same test names
across executions from different people or from different directories.
[1] - https://avocado-framework.readthedocs.io/en/69.0/ReferenceGuide.html#test-id
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
tests/Makefile.include | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index 0cd5f465b7..991ad05aea 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -1147,7 +1147,7 @@ check-acceptance: check-venv $(TESTS_RESULTS_DIR)
--show=$(AVOCADO_SHOW) run --job-results-dir=$(TESTS_RESULTS_DIR) \
--filter-by-tags-include-empty --filter-by-tags-include-empty-key \
$(AVOCADO_TAGS) \
- --failfast=on $(SRC_PATH)/tests/acceptance, \
+ --failfast=on tests/acceptance, \
"AVOCADO", "tests/acceptance")
# Consolidated targets
--
2.21.0
next prev parent reply other threads:[~2019-06-06 21:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 21:14 [Qemu-devel] [PATCH v6 0/7] Add "boot_linux" acceptance test Cleber Rosa
2019-06-06 21:14 ` Cleber Rosa [this message]
2019-06-06 21:14 ` [Qemu-devel] [PATCH v6 2/7] Acceptance tests: keep a stable reference to the QEMU build dir Cleber Rosa
2019-06-06 21:14 ` [Qemu-devel] [PATCH v6 3/7] Acceptance tests: add the build directory to the system PATH Cleber Rosa
2019-06-06 21:14 ` [Qemu-devel] [PATCH v6 4/7] Acceptance tests: depend on qemu-img Cleber Rosa
2019-06-06 21:14 ` [Qemu-devel] [PATCH v6 5/7] Add "boot_linux" test for x86_64 and pc and q35 machine types Cleber Rosa
2019-06-06 21:14 ` [Qemu-devel] [PATCH v6 6/7] Add "boot_linux" test for aarch64 and virt machine type Cleber Rosa
2019-06-06 21:14 ` [Qemu-devel] [PATCH v6 7/7] [RFC]: use Avocado data drainer for console logging Cleber Rosa
2019-06-06 23:03 ` [Qemu-devel] [PATCH v6 0/7] Add "boot_linux" acceptance test no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606211414.8681-2-crosa@redhat.com \
--to=crosa@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=cohuck@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sameo@linux.intel.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).