From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C714C28CC3 for ; Fri, 7 Jun 2019 03:30:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C4752080C for ; Fri, 7 Jun 2019 03:30:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pUMDk1UX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C4752080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45748 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZ5Zy-00016c-0y for qemu-devel@archiver.kernel.org; Thu, 06 Jun 2019 23:30:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55934) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZ5YV-0000cr-U0 for qemu-devel@nongnu.org; Thu, 06 Jun 2019 23:28:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZ5YU-0004tM-Ov for qemu-devel@nongnu.org; Thu, 06 Jun 2019 23:28:39 -0400 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]:42768) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hZ5YQ-0004ix-TK; Thu, 06 Jun 2019 23:28:35 -0400 Received: by mail-pg1-x544.google.com with SMTP id e6so379919pgd.9; Thu, 06 Jun 2019 20:28:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wvfTEi6MWh5ZptHrzsO5+RfC2vsLZDoHxbRpf2T/6Xw=; b=pUMDk1UXCLrorkTKF3MyTZlqXsyOPCvSyVQgYRPebUKn/mEN1qmMnyZB/BQ6WzLoXJ /uenrci0rP4Uz0ft1VnlHDXEwsIllkChnuTfkLXser1HIsKPmyfIWOKfWgL9DR4a1lcV 6fxW1UdY7t8K1dVHc/mQGoYZM63LrxA6ZxEWGnX2yzt+NucXU4G5yApJMSU6cWsRIfPw lRjAGms7VLoXaXiYOfGW2TlQTSOB3KQJycJA5BV/daesyrWxecEjn/JJMTMrnkQTVnig xtwDkONEkTAJJyS+lqN2QgAEfyF5iv7VKiMv5IAegIZUSF6Zf7Kw+x3MP3kPFThGUWBs BbDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wvfTEi6MWh5ZptHrzsO5+RfC2vsLZDoHxbRpf2T/6Xw=; b=rKbfJHInOHW6q2qcE85zRfZPTVjohhvyvngT30F4GGrDwNNiGDDh9xiWXMetWdBHG+ GCotMmRDPCTW9V6jh4r2MBPjrvfHNPHxeySpD1DuzyXDTvasQ4/fZkexGY/4aOunDfnl jFZdx0FMoBh2bMkMx9YRh3z6D7r0j35RfrM4PCCPq6XwLogn25SDTnP9B7n/o1kBR6YA ueyBH7itPkEtnFnLQcWUX3yGeQTvKOJj55slOB3OZy9/gQStqzGGERNRTc5CRwejI49q 7ZhFNcYREeMcv61DEUCeziLLrbclgbpbut0wBO95/KkMJrUG5BX69/6nOut73+TNO5bZ Dg0g== X-Gm-Message-State: APjAAAXorKLsS/2CLOqw2a+vmPdS3iSwzHOWKFbKGOEWg+fR5TFDqAGe ua22QW6x8bqdPZg94x1TKwQ= X-Google-Smtp-Source: APXvYqw45daic3sH9B1u63zNbhZYxqEb8CHP8ykypVeqG4TSatur1i0DqUcGBjEb8deAnBE35zZi+Q== X-Received: by 2002:a62:2643:: with SMTP id m64mr54794350pfm.46.1559878113522; Thu, 06 Jun 2019 20:28:33 -0700 (PDT) Received: from localhost.localdomain (sp183-74-192-44.msb.spmode.ne.jp. [183.74.192.44]) by smtp.gmail.com with ESMTPSA id s24sm548820pfh.133.2019.06.06.20.28.31 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 06 Jun 2019 20:28:33 -0700 (PDT) Date: Fri, 7 Jun 2019 12:28:26 +0900 From: Lucien Murray-Pitts To: Aleksandar Markovic Message-ID: <20190607032825.GA5123@localhost.localdomain> References: <20190606234125.GA4830@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::544 Subject: Re: [Qemu-devel] [PATCH v2] m68k comments break patch submission due to being incorrectly formatted X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jun 07, 2019 at 01:58:05AM +0200, Aleksandar Markovic wrote: > On Jun 7, 2019 1:42 AM, "Lucien Murray-Pitts" > wrote: > > > > Altering all comments in target/m68k to match Qemu coding styles so that > future > > patches wont fail due to style breaches. > > > > Are you saying that patches fail checkpatch checks even if the new code has > only correct comment format? (Or, in other words, that checkpatch detects > comment-related errors in unchanged code, and reports them as the > errors/warnings in the patch in question?) I just want to understand what > is the obstacle you are trying to remove. > > Thanks, Aleksandar > [SNIP of PATCH] checkpatch is correctly identifying the wrong style in the changed code. This changed code contains the original comments with ADDITIONAL edits resulting in pachew/checkpatch complaining. The m68k is, by my guess, older code and nearly all the comments are different from the style guide. Some are "/**" or "/*commment here...." and so on. Since I had a patch AUTO-FLAGGED by patchew for this reason I thought I would start with a cleanup of the comments to bring them into line with the style. Cheers, Luc