From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45A7DC2BCA1 for ; Fri, 7 Jun 2019 14:13:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1839C206E0 for ; Fri, 7 Jun 2019 14:13:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1839C206E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51560 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZFcr-0007WG-Bc for qemu-devel@archiver.kernel.org; Fri, 07 Jun 2019 10:13:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48497) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZFUc-00026X-FA for qemu-devel@nongnu.org; Fri, 07 Jun 2019 10:05:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZFUR-0000xg-N9 for qemu-devel@nongnu.org; Fri, 07 Jun 2019 10:05:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44320) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hZFU1-0007id-4A; Fri, 07 Jun 2019 10:04:42 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DE4C3981D3; Fri, 7 Jun 2019 14:04:02 +0000 (UTC) Received: from redhat.com (ovpn-112-33.ams2.redhat.com [10.36.112.33]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6ACBF7FD0B; Fri, 7 Jun 2019 14:04:00 +0000 (UTC) Date: Fri, 7 Jun 2019 15:03:57 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Kevin Wolf Message-ID: <20190607140357.GK28838@redhat.com> References: <20190607135430.22149-1-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190607135430.22149-1-kwolf@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 07 Jun 2019 14:04:12 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [RFC PATCH 00/10] monitor: Split monitor.c in core/HMP/QMP/misc X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: dgilbert@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org, armbru@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jun 07, 2019 at 03:54:20PM +0200, Kevin Wolf wrote: > monitor.c mixes a lot of different things in a single file: The core > monitor infrastructure, HMP infrastrcture, QMP infrastructure, and the > implementation of several HMP and QMP commands. Almost worse, struct > Monitor mixes state for HMP, for QMP, and state actually shared between > all monitors. monitor.c must be linked with a system emulator and even > requires per-target compilation because some of the commands it > implements access system emulator state. > > The reason why I care about this is that I'm working on a protoype for a > storage daemon, which wants to use QMP (but probably not HMP) and > obviously doesn't have any system emulator state. So I'm interested in > some core monitor parts that can be linked to non-system-emulator tools. > > This series first creates separate structs MonitorQMP and MonitorHMP > which inherit from Monitor, and then moves the associated infrastructure > code into separate source files. > > While the split is probably not perfect, I think it's an improvement of > the current state even for QEMU proper, and it's good enough so I can > link my storage daemon against just monitor/core.o and monitor/qmp.o and > get a useless QMP monitor that parses the JSON input and rejects > everything as an unknown command. > > Next I'll try to teach it a subset of QMP commands that can actually be > supported in a tool, but while there will be a few follow-up patches to > achieve this, I don't expect that this work will bring up much that > needs to be changed in the splitting process done in this series. > > Kevin Wolf (10): > monitor: Remove unused password prompting fields > monitor: Split monitor_init in HMP and QMP function > monitor: Make MonitorQMP a child class of Monitor > monitor: Create MonitorHMP with readline state > monitor: Move cmd_table to MonitorHMP > Move monitor.c to monitor/misc.c > monitor: Create monitor_int.h with common definitions > monitor: Split out monitor/qmp.c > monitor: Split out monitor/hmp.c > monitor: Split out monitor/core.c > > include/monitor/monitor.h | 8 +- > monitor/monitor_int.h | 207 ++ > hmp.c | 4 +- > monitor.c | 4727 ------------------------------------- > monitor/core.c | 604 +++++ > monitor/hmp.c | 1351 +++++++++++ > monitor/misc.c | 2406 +++++++++++++++++++ > monitor/qmp.c | 404 ++++ > Makefile.objs | 1 + > Makefile.target | 3 +- > monitor/Makefile.objs | 2 + It will be nice to have the monitor code split up a bit more. I'm not a fan, however, of having both $ROOT/qmp.c and $ROOT/monitor/qmp.c Likwise $ROOT/hmp.c and $ROOT/monitor/hmp.c. Can we move those other existing files out of the root dir, into monitor/, so we don't have two files with the same name in different dirs. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|