From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C685C2BCA1 for ; Fri, 7 Jun 2019 14:27:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7486320657 for ; Fri, 7 Jun 2019 14:27:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7486320657 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51720 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZFpi-0002KV-Na for qemu-devel@archiver.kernel.org; Fri, 07 Jun 2019 10:27:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49464) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZFXF-0004Ea-GU for qemu-devel@nongnu.org; Fri, 07 Jun 2019 10:08:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZFX9-00067r-8E for qemu-devel@nongnu.org; Fri, 07 Jun 2019 10:07:58 -0400 Received: from foss.arm.com ([217.140.110.172]:39408) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hZFWm-0005Qp-Km; Fri, 07 Jun 2019 10:07:32 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B0300337; Fri, 7 Jun 2019 07:07:28 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0A0583F71A; Fri, 7 Jun 2019 07:07:27 -0700 (PDT) Date: Fri, 7 Jun 2019 15:07:21 +0100 From: Mark Rutland To: Peter Maydell Message-ID: <20190607140720.GA18706@lakrids.cambridge.arm.com> References: <20190516144733.32399-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190516144733.32399-1-peter.maydell@linaro.org> User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.140.110.172 Subject: Re: [Qemu-devel] [PATCH v2 0/4] hw/arm/boot: handle large Images more gracefully X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, Richard Henderson , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Peter, Sorry for the delay in replying to this... On Thu, May 16, 2019 at 03:47:29PM +0100, Peter Maydell wrote: > > This patchset attempts to fix https://bugs.launchpad.net/qemu/+bug/1823998 > which reports that we don't handle kernels larger than 128MB > correctly, because we allow the initrd to be placed over the > tail end of the kernel. AArch64 kernel Image files (since v3.17) > report the total size they require (including any BSS area that > isn't in the Image itself), so we can use that to be sure we > place the initrd sufficiently far into the RAM. > > Patches 1 and 2 are new since v1; patches 3 and 4 are the old > patches 1 and 2 (and are basically unchanged since v1). > > Patches 1 and 2 in this series are new. Patch 1 fixes bugs > in the existing code where we were assuming that we could > treat info->ram_size as the address of the end of RAM, which > isn't true if the RAM doesn't start at address 0. (This > generally went unnoticed thanks to the magic of unsigned integer > underflow turning end-start calculations into very large max_size > values for load_ramdisk_as() and friends.) > Patch 2 adds some explicit checks that we don't try to put things > entirely off the end of RAM (which avoids those accidental > underflows). > Patch 3 in this series adjusts our "where do we put the initrd" > heuristic so that it always places it at least after whatever > our best guess at the kernel size is. (This might still not > be right for images like self-decompressing 32-bit kernels, where > there's no way to know how big the kernel will be after > decompression.) > Patch 4 makes load_aarch64_image() return the > kernel size as indicated in the Image file header, so that for > the specific case of AArch64 Image files we will definitely not > put the initrd on top of them. With all 4 patches applied, I'm able to boot kernels with large BSS segments (~128M, ~512M, and ~1G), and I get sensible warnings when they are impossible to boot, e.g. # 124M of RAM [mark@gravadlaks:~/repro]% ./vmboot.sh ~/Image.test-128M qemu-system-aarch64: kernel '/home/mark/Image.test-128M' is too large to fit in RAM (kernel size 155500544, RAM size 130023424) # 150M of RAM [mark@gravadlaks:~/repro]% ./vmboot.sh ~/Image.test-128M qemu-system-aarch64: Not enough space for DTB after kernel/initrd So feel free to add: Tested-by: Mark Rutland Thanks for putting this together; this is _really_ useful for my testing setup, and the warnings above are likely to save people a lot of head-scratching in future. It would be great to see this merged. :) Thanks, Mark.