From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Yoshinori Sato <ysato@users.sourceforge.jp>,
qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [Qemu-devel] [PATCH v18 22/29] target/rx: Use prt_ldmi for XCHG_mr disassembly
Date: Fri, 7 Jun 2019 17:37:18 +0200 [thread overview]
Message-ID: <20190607153725.18055-23-philmd@redhat.com> (raw)
In-Reply-To: <20190607153725.18055-1-philmd@redhat.com>
From: Richard Henderson <richard.henderson@linaro.org>
Note that the ld == 3 case handled by prt_ldmi is decoded as
XCHG_rr and cannot appear here.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Message-Id: <20190607091116.49044-21-ysato@users.sourceforge.jp>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/rx/disas.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/target/rx/disas.c b/target/rx/disas.c
index 515b365528..db10385fd0 100644
--- a/target/rx/disas.c
+++ b/target/rx/disas.c
@@ -366,13 +366,7 @@ static bool trans_XCHG_rr(DisasContext *ctx, arg_XCHG_rr *a)
/* xchg dsp[rs].<mi>,rd */
static bool trans_XCHG_mr(DisasContext *ctx, arg_XCHG_mr *a)
{
- static const char msize[][4] = {
- "b", "w", "l", "ub", "uw",
- };
- char dsp[8];
-
- rx_index_addr(ctx, dsp, a->ld, a->mi);
- prt("xchg\t%s[r%d].%s, r%d", dsp, a->rs, msize[a->mi], a->rd);
+ prt_ldmi(ctx, "xchg", a->ld, a->mi, a->rs, a->rd);
return true;
}
--
2.20.1
next prev parent reply other threads:[~2019-06-07 17:08 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 15:36 [Qemu-devel] [PATCH v18 00/29] Add RX archtecture support Philippe Mathieu-Daudé
2019-06-07 15:36 ` [Qemu-devel] [PATCH v18 01/29] target/rx: TCG translation Philippe Mathieu-Daudé
2019-06-07 15:36 ` [Qemu-devel] [PATCH v18 02/29] target/rx: TCG helper Philippe Mathieu-Daudé
2019-06-07 15:36 ` [Qemu-devel] [PATCH v18 03/29] target/rx: CPU definition Philippe Mathieu-Daudé
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 04/29] !fixup " Philippe Mathieu-Daudé
2019-06-07 18:02 ` Eric Blake
2019-06-07 18:06 ` Philippe Mathieu-Daudé
2019-06-10 12:59 ` Igor Mammedov
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 05/29] " Philippe Mathieu-Daudé
2019-06-07 15:43 ` Philippe Mathieu-Daudé
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 06/29] target/rx: RX disassembler Philippe Mathieu-Daudé
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 07/29] hw/intc: RX62N interrupt controller (ICUa) Philippe Mathieu-Daudé
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 08/29] hw/timer: RX62N internal timer modules Philippe Mathieu-Daudé
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 09/29] hw/char: RX62N serial communication interface (SCI) Philippe Mathieu-Daudé
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 10/29] hw/rx: RX Target hardware definition Philippe Mathieu-Daudé
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 11/29] !fixup " Philippe Mathieu-Daudé
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 12/29] qemu/bitops.h: Add extract8 and extract16 Philippe Mathieu-Daudé
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 13/29] hw/registerfields.h: Add 8bit and 16bit register macros Philippe Mathieu-Daudé
2019-06-07 20:56 ` Alistair Francis
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 14/29] target/rx: Convert to CPUClass::tlb_fill Philippe Mathieu-Daudé
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 15/29] target/rx: Add RX to SysEmuTarget Philippe Mathieu-Daudé
2019-06-07 18:04 ` Eric Blake
2019-06-07 18:08 ` Philippe Mathieu-Daudé
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 16/29] tests: Add rx to machine-none-test.c Philippe Mathieu-Daudé
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 17/29] hw/rx: Honor -accel qtest Philippe Mathieu-Daudé
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 18/29] Add rx-softmmu Philippe Mathieu-Daudé
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 19/29] MAINTAINERS: Add RX Philippe Mathieu-Daudé
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 20/29] target/rx: Disassemble rx_index_addr into a string Philippe Mathieu-Daudé
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 21/29] target/rx: Replace operand with prt_ldmi in disassembler Philippe Mathieu-Daudé
2019-06-07 15:37 ` Philippe Mathieu-Daudé [this message]
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 23/29] target/rx: Emit all disassembly in one prt() Philippe Mathieu-Daudé
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 24/29] target/rx: Collect all bytes during disassembly Philippe Mathieu-Daudé
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 25/29] target/rx: Dump bytes for each insn " Philippe Mathieu-Daudé
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 26/29] target/rx: Restrict access to extable[] Philippe Mathieu-Daudé
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 27/29] hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core Philippe Mathieu-Daudé
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 28/29] hw/rx: Fix comments Philippe Mathieu-Daudé
2019-06-07 16:57 ` Peter Maydell
2019-06-07 15:37 ` [Qemu-devel] [PATCH v18 29/29] BootLinuxConsoleTest: Test the RX-Virt machine Philippe Mathieu-Daudé
2019-06-08 0:50 ` [Qemu-devel] [PATCH v18 00/29] Add RX archtecture support no-reply
2019-06-10 6:03 ` Yoshinori Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190607153725.18055-23-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).